-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRIU resets j.l.VirtualThread.ForkJoinPool.parallelism after restore #17618
CRIU resets j.l.VirtualThread.ForkJoinPool.parallelism after restore #17618
Conversation
4085b76
to
bd167d1
Compare
bd167d1
to
ed5de2d
Compare
a29effa
to
a76f932
Compare
If there is no system property jdk.virtualThreadScheduler.parallelism set at VM startup, j.l.VirtualThread.ForkJoinPool.parallelism value is reset to match Runtime.getRuntime().availableProcessors() after CRIU restore; Added VM_VMHelpers methods getStaticFieldObject/findinstanceFieldOffset/setObjectFieldI32; Changed hashClassTableAt to peekClassHashTable; Minor refactoring; Added tests. Signed-off-by: Jason Feng <fengj@ca.ibm.com>
a76f932
to
ac50591
Compare
Im wondering if we should just use vmconstantpool for this. Im trying to think of a downside, but I think the cost to startup is negligeable |
This mimics the earlier modification of |
I mention it here, because with VirtualThreads ForkJoinPool will certainly be used. I guess it may not be with pre-JDK 21 builds |
jenkins compile win jdk8 |
jenkins test sanity alinux64 jdk21 |
CRIU resets
j.l.VirtualThread.ForkJoinPool.parallelism
after restoreIf there is no system property
jdk.virtualThreadScheduler.parallelism
set at VM startup,j.l.VirtualThread.ForkJoinPool.parallelism
value is reset to matchRuntime.getRuntime().availableProcessors()
after CRIUrestore;
Added
VM_VMHelpers
methodsgetStaticFieldObject
/findinstanceFieldOffset
/setObjectFieldI32
;Changed
hashClassTableAt
topeekClassHashTable
;Minor refactoring;
Added tests.
Signed-off-by: Jason Feng fengj@ca.ibm.com