update TestNG to 6.14.2 version to fix false positive test result #1398
Conversation
|
Please also update TestNG jar version in readme. Thanks. |
terryzuoty
force-pushed
the
cbuild
branch
6 times, most recently
from
0efec8a to
793e706
Compare
terryzuoty
changed the title
terryzuoty
force-pushed
the
cbuild
branch
2 times, most recently
from
04f4e5a to
37702d2
Compare
|
Hi @llxia @smlambert , this PR is ready for review |
|
Could we add description for why we have to separate JLM_Tests_interface, remove gpu exclude, and exclude on win? Thanks. |
|
they were in the commit message, updated the description of this PR. |
terryzuoty
force-pushed
the
cbuild
branch
3 times, most recently
from
54f4d0d to
27206e3
Compare
terryzuoty
force-pushed
the
cbuild
branch
5 times, most recently
from
37b9b7b to
64f8842
Compare
* TestNG before 6.14 treats configuration failure as pass, this has been fixed since TestNG 6.14, update TestNG version to 6.14.2 to fix this bug in product build * separate JLM test targets to avoid OOM failure * re-enable tests which are fixed and passing * update exclude file which failed on TestNG 6.14.2 * exclude reattachAfterExit from win since it is not supported on win * disable testSoftMxRemote tests since it failed at setup stage [ci skip] fixed:eclipse-openj9#1367 fixed:eclipse-openj9#1112 Issue:eclipse-openj9#1454 Signed-off-by: Tianyu Zuo <tianyu@ca.ibm.com>
|
Jenkins test sanity all |
|
This PR changed sha1 to match new testng jar in getDependencies.pl. PR builds failed because they are using staged old testng.jar from Jenkins https://ci.eclipse.org/openj9/job/test.getDependency/ https://ci.eclipse.org/openj9/job/test.getDependency/ should be rerun after the change is delivered to make sure future PR builds is using up-to-date jar. |
|
Thanks @llxia - I forgot that this is how the getDependency currently is called at OpenJ9 (could likely rethink this approach, and consider same approach as for freemarker.jar - try to fetch it, and only if fails, fall back to pre-fetched version). Will merge this change (which has been verified in internal personal builds) and launch a getdependency job. |
|
Thanks for launching the getdependency job Shelley |
|
This was a big PR to pull together (given all the internal dependencies also), thanks for sticking with it @TianyuZuo ! |
fixed:#1367
fixed:#1112
Issue:#1454
Signed-off-by: Tianyu Zuo tianyu@ca.ibm.com