Add Slack notification on failure #1349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[skip ci] Fixes eclipse-openj9#975 Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
DanHeidinga
reviewed
Mar 6, 2018
| post { | ||
| failure { | ||
| slackSend channel: '#jenkins', color: 'danger', message: "Failed: ${env.JOB_NAME} #${env.BUILD_NUMBER} (<${env.BUILD_URL}|Open>)" |
There was a problem hiding this comment.
Can you expand on the message? It will be easier for the people viewing the #jenkins channel if the message is something like "OMR mirror to openj9-omr failed: ${env.JOB_NAME} #${env.BUILD_NUMBER} (<${env.BUILD_URL}|Open>)"
There was a problem hiding this comment.
@AdamBrousseau pointed out that the job names are reasonably descriptive so the message change isn't necessary
| post { | ||
| failure { | ||
| slackSend channel: '#jenkins', color: 'danger', message: "Failed: ${env.JOB_NAME} #${env.BUILD_NUMBER} (<${env.BUILD_URL}|Open>)" |
There was a problem hiding this comment.
Does this pick up the same pipeline configuration or does it need to be told which Slack instance in some other way?
There was a problem hiding this comment.
and that the slack is picked up from the Jenkins config.
|
Skipping the PR build as this can only be tested by a failing OMR mirror build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[skip ci]
Fixes #975
Signed-off-by: Adam Brousseau adam.brousseau88@gmail.com