Use redirectIO() in TestOpenJ9DiagnosticsMXBean #11058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llxia for review pls. I'd like to get this in today so the Windows builds aren't hanging all weekend. |
smlambert
approved these changes
Oct 30, 2020
The child process was hanging on Windows due to not reading the child process IO. Unexclude the test on Windows 32-bit. Issue eclipse-openj9#11055 [ci skip] Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
|
LGTM, thanks for launching the Grinders, those are sufficient to verify the change (no further PR testing required). |
|
Added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The child process was hanging on Windows due to not reading the child
process IO. Unexclude the test on Windows 32-bit.
Fixes #11055
Fixes #2213
Tested via grinders using JVMs from the last night's OpenJ9 build, these all passed.
jdk8 Windows https://ci.eclipse.org/openj9/view/Test/job/Grinder/1148
jdk11 Windows https://ci.eclipse.org/openj9/view/Test/job/Grinder/1151
jdk8 Windows 32-bit https://ci.eclipse.org/openj9/view/Test/job/Grinder/1149
jdk8 zLinux https://ci.eclipse.org/openj9/view/Test/job/Grinder/1150