Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert OMR Acceptance build to use new Jenkins Pipeline Code #972

Closed
AdamBrousseau opened this issue Jan 18, 2018 · 8 comments
Closed

Convert OMR Acceptance build to use new Jenkins Pipeline Code #972

AdamBrousseau opened this issue Jan 18, 2018 · 8 comments
Labels
comp:build enhancement good first issue Good for newcomers

Comments

@AdamBrousseau
Copy link
Contributor

Pipeline-OMR-Acceptance
Related #660

Currently the code is in the groovy sandbox in the job config. Should be relatively straight forward to add a Jenkins file that reuses the new code.
@AdamBrousseau
Copy link
Contributor Author

The existing OMR Acceptance build tests JDK9 sanity, when I add the pipeline code for this do we want 8 or 9 or both? @pshipton @DanHeidinga

AdamBrousseau added a commit to AdamBrousseau/openj9 that referenced this issue Feb 5, 2018
@AdamBrousseau
Add Pipeline for OMR Acceptance
07dcd85 
[skip ci]

Issue eclipse-openj9#972

Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
@pshipton
Copy link
Member

pshipton commented Feb 6, 2018

+1 for both, as we don't want omr updates to break either one.

@DanHeidinga
Copy link
Member

Will the 8 & 9 builds be run in parallel or serially? If parallel, I concur with Peter (assuming we have sufficient machines to keep build times to a reasonable length of time)

@AdamBrousseau
Copy link
Contributor Author

Parallel

This was referenced Mar 5, 2018
Merged
Closed
AdamBrousseau added a commit to AdamBrousseau/openj9-website that referenced this issue Mar 6, 2018
@AdamBrousseau
Add Slack notification on failure
b55287d 
Issue eclipse-openj9/openj9#972

Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
@AdamBrousseau
Copy link
Contributor Author

Now that we have stable 10 sanity builds, do we want to add 10 to the OMR acceptance build or replace 9 with 10? We usually only run 2-3/day (every OMR PR merge). The current builds (z/p JDK9) usually take about 2 hours. @DanHeidinga @pshipton

@DanHeidinga
Copy link
Member

As JDK9 is already out of support, we should be transitioning our builds to do both 8 & 10.

AdamBrousseau added a commit to AdamBrousseau/openj9 that referenced this issue Apr 27, 2018
@AdamBrousseau
Initial commit for OMR-Acceptance build
2df1792 
- Launch Compile & Sanity X JDK8,10 X SPEC
- Add params to workflow function
- Change build stage name to match JOB_NAME
- Add pipeline for Promote job
- Move reusable functions to common file

[ci skip]

Issue eclipse-openj9#972

Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
@AdamBrousseau
Copy link
Contributor Author

The PR has been merged. Given the time of day/week I will wait till Monday to reconfigure the existing build to use the new code.

@AdamBrousseau
Copy link
Contributor Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp:build enhancement good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AdamBrousseau @DanHeidinga @pshipton