Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup line in VM_Test build.xml not working as expected #1800

Closed
AdamBrousseau opened this issue Apr 30, 2018 · 4 comments
Closed

Cleanup line in VM_Test build.xml not working as expected #1800

AdamBrousseau opened this issue Apr 30, 2018 · 4 comments

Comments

@AdamBrousseau
Copy link
Contributor

AdamBrousseau commented Apr 30, 2018

https://github.com/eclipse/openj9/blob/f66506e7a528340d176260c3af47c63cf66979ec/test/functional/VM_Test/build.xml#L134

	<target name="clean" depends="dist" description="clean up">
		<!-- Delete the ${build} directory trees -->
		<delete dir="${build}" />
		<delete dir="${data}/*.class" />
		<delete dir="${databin}" />
	</target>

Specifically:
<delete dir="${data}/*.class" />

I believe the intention of this line is to delete all the class files within the data directory. I think the syntax currently reads "Delete all directories named *.class in the data directory" (where *.class is the actual name of a directory).
Ant doc: https://ant.apache.org/manual/Tasks/delete.html
I created a simple test case by hand and tried it on Windows and xLinux and it doesn't delete any *.class files in my directory.
Changing the syntax to the following removes the class files in my dir.

<delete>
   <fileset dir="${data}" includes="**/*.class"/>
</delete>

fyi @llxia @renfeiw @TianyuZuo

@AdamBrousseau
Copy link
Contributor Author

I have the change above made in a pushed branch I am using to test #1662 (comment) .
Let me know if you want me to open a PR.

@renfeiw
Copy link
Contributor

renfeiw commented Apr 30, 2018

Thanks for the fix, it would be appreciated if you can open a PR.

@AdamBrousseau
Copy link
Contributor Author

see #1803

@AdamBrousseau
Copy link
Contributor Author

Good news is this fixes my issue noted above too

AdamBrousseau added a commit to AdamBrousseau/openj9 that referenced this issue May 1, 2018
- Previous syntax was incorrect for intended purpose
- Change syntax to delete all class files in 'data'
  directory and all subdirectories.

[skip ci]

Fixes eclipse-openj9#1800

Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants