-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup line in VM_Test build.xml not working as expected #1800
Labels
Comments
I have the change above made in a pushed branch I am using to test #1662 (comment) . |
Thanks for the fix, it would be appreciated if you can open a PR. |
see #1803 |
Good news is this fixes my issue noted above too |
AdamBrousseau
added a commit
to AdamBrousseau/openj9
that referenced
this issue
May 1, 2018
- Previous syntax was incorrect for intended purpose - Change syntax to delete all class files in 'data' directory and all subdirectories. [skip ci] Fixes eclipse-openj9#1800 Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://github.com/eclipse/openj9/blob/f66506e7a528340d176260c3af47c63cf66979ec/test/functional/VM_Test/build.xml#L134
Specifically:
<delete dir="${data}/*.class" />
I believe the intention of this line is to delete all the class files within the
data
directory. I think the syntax currently reads "Delete all directories named*.class
in thedata
directory" (where *.class is the actual name of a directory).Ant doc: https://ant.apache.org/manual/Tasks/delete.html
I created a simple test case by hand and tried it on Windows and xLinux and it doesn't delete any *.class files in my directory.
Changing the syntax to the following removes the class files in my dir.
fyi @llxia @renfeiw @TianyuZuo
The text was updated successfully, but these errors were encountered: