Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MQTT for monitoring #239

Draft
wants to merge 8 commits into
base: development
Choose a base branch
from
Draft

MQTT for monitoring #239

wants to merge 8 commits into from

Conversation

mbfm
Copy link
Contributor

@mbfm mbfm commented May 22, 2024

No description provided.

@mbfm
Copy link
Contributor Author

mbfm commented May 22, 2024

Hey @eet1mu3, I've opened a draft PR for you, to make it easier to track that work is happening on this branch and to have a place to discuss it.

Two points I wanted to point out right away:

  • You rebased onto the main-branch, but in our current workflow, you'd want to rebase onto development instead. We merge all PRs onto development and when we feel like it's somewhat stabilized, we then merge from development onto main and create a release for it.

  • And you merged issue-171-revised into your branch. That's a stale branch. We've continued developing here: New Deployment Infrastructure (Issue 171) #225
    Basically, we had to transfer the work to two colleagues, who don't yet have commit permissions, so couldn't continue work on that branch.
    We hope to merge that PR into development in the coming days.
    The code, that you integrated with, didn't change much since that branch got abandoned, so hopefully you won't see too many changes, but yeah, just a heads-up that you might see breakages with the way you had merged things.

@mbfm mbfm force-pushed the development branch 2 times, most recently from b3ac8c0 to 840ae07 Compare September 16, 2024 09:49
@mbfm mbfm force-pushed the development branch 4 times, most recently from b77afe5 to d12c76f Compare February 11, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants