Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EDGAR: Issue 132 use client secret and client id from setup string #192

Merged
merged 1 commit into from
Apr 18, 2024
Merged

EDGAR: Issue 132 use client secret and client id from setup string #192

merged 1 commit into from
Apr 18, 2024

Conversation

mtwardawski
Copy link
Contributor

No description provided.

@mtwardawski mtwardawski force-pushed the issue-132_edgar_should_use_client_id_and_client_secret branch 2 times, most recently from f26b379 to 5c0e20c Compare April 15, 2024 07:41
reimarstier
reimarstier requested changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@reimarstier reimarstier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed earlier I'd like to change the authentication config to indicate when the authentication is disabled via a rust enum.

opendut-types/src/util/net.rs Outdated Show resolved Hide resolved
opendut-edgar/edgar.toml Outdated Show resolved Hide resolved
opendut-edgar/src/setup/tasks/write_configuration.rs Outdated Show resolved Hide resolved
@voelkera voelkera force-pushed the issue-132_edgar_should_use_client_id_and_client_secret branch from 615f28c to 1d78272 Compare April 15, 2024 11:53
@mtwardawski mtwardawski force-pushed the issue-132_edgar_should_use_client_id_and_client_secret branch 3 times, most recently from 646fd3c to 3e07104 Compare April 18, 2024 12:07
@mtwardawski @reimarstier
EDGAR: Issue-132 - Edgar uses client secret and client id from provid…
b360805 
…ed setup string and writes those information in its toml file if they are not existent yet.
@reimarstier reimarstier force-pushed the issue-132_edgar_should_use_client_id_and_client_secret branch from 3e07104 to b360805 Compare April 18, 2024 14:53
@reimarstier reimarstier merged commit ba12fae into eclipse-opendut:development Apr 18, 2024
22 checks passed
@mtwardawski mtwardawski deleted the issue-132_edgar_should_use_client_id_and_client_secret branch July 12, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reimarstier reimarstier reimarstier requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtwardawski @reimarstier