Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add credential fields to setup-string #175

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Add credential fields to setup-string #175

merged 1 commit into from
Apr 9, 2024

Conversation

reimarstier
Copy link
Contributor

@reimarstier reimarstier commented Apr 3, 2024 •
edited
Loading

solves #112

  • Cleanup releases/v0.1.0/CHANGELOG.md

@reimarstier reimarstier requested review from mtwardawski and mbfm April 3, 2024 14:34
@reimarstier reimarstier changed the base branch from main to development April 3, 2024 14:36
@reimarstier reimarstier force-pushed the issue-112 branch 5 times, most recently from b2b3daa to ba420e9 Compare April 4, 2024 12:55
mbfm
mbfm approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@mbfm mbfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed the code style and left some notes. It's only minor problems, though.

.ci/docker/keycloak/docker-compose.yml Outdated Show resolved Hide resolved
opendut-carl/opendut-carl-api/src/carl/auth/manager.rs Outdated Show resolved Hide resolved
opendut-carl/opendut-carl-api/src/carl/auth/manager.rs Outdated Show resolved Hide resolved
opendut-carl/opendut-carl-api/src/carl/auth/manager.rs Outdated Show resolved Hide resolved
opendut-carl/src/lib.rs Outdated Show resolved Hide resolved
opendut-carl/src/peer/oidc_client_manager.rs Outdated Show resolved Hide resolved
opendut-carl/src/peer/oidc_client_manager.rs Outdated Show resolved Hide resolved
opendut-carl/src/peer/oidc_client_manager.rs Outdated Show resolved Hide resolved
opendut-carl/src/peer/oidc_client_manager.rs Outdated Show resolved Hide resolved
opendut-carl/src/peer/oidc_client_manager.rs Outdated Show resolved Hide resolved
mtwardawski
mtwardawski reviewed Apr 8, 2024
View reviewed changes
opendut-lea/src/app.rs Outdated Show resolved Hide resolved
@reimarstier reimarstier force-pushed the issue-112 branch 2 times, most recently from b2d8d0a to 8cc23e7 Compare April 8, 2024 13:15
@reimarstier reimarstier merged commit c59314e into development Apr 9, 2024
43 checks passed
@reimarstier reimarstier deleted the issue-112 branch April 10, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtwardawski mtwardawski mtwardawski left review comments

@mbfm mbfm mbfm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reimarstier @mbfm @mtwardawski