Update uses of checkArrayCompClassPrimitiveValueType #7477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@a7ehuo, @0xdaryl, may I ask you to review this change? This pull request requires a coordinated merge with eclipse-openj9/openj9#20291 |
|
Jenkins build all |
0xdaryl
approved these changes
Oct 7, 2024
The utility method checkArrayCompClassPrimitiveValueType has been renamed testIsArrayClassNullRestrictedType, to reflect more recent terminology, and it no longer expects an "if" OpCode argument. Instead, it generates IL that yields a zero or non-zero result to indicate whether the array is null-restricted. This change updates uses of that method to branch appropriately based on the result of the IL produced by testIsArrayClassNullRestrictedType. Signed-off-by: Henry Zongaro <zongaro@ca.ibm.com>
hzongaro
force-pushed
the
assigning-null-to-non-nullable-array-throws-ArrayStoreException
branch
from
266df31 to
f02e24b
Compare
|
Rebased changes onto current HEAD of openj9 branch of https://github.com/eclipse-openj9/openj9-omr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The utility method
checkArrayCompClassPrimitiveValueTypehas been renamedtestIsArrayClassNullRestrictedType, to reflect more recent terminology, and it no longer expects an "if" OpCode argument. Instead, it generates IL that yields a zero or non-zero result to indicate whether the array is null-restricted. This change updates uses of that method to branch appropriately based on the result of the IL produced bytestIsArrayClassNullRestrictedType.This change is in OpenJ9-specific code.