Change arraycmp length child to 64 bits #7313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
arch:aarch64
arch:power
arch:z
comp:compiler
comp:test
comp:tril
labels
Spencer-Comin
force-pushed
the
arraycmp-64
branch
2 times, most recently
from
c758d04 to
b4cf92b
Compare
Spencer-Comin
force-pushed
the
arraycmp-64
branch
from
b4cf92b to
77b15ab
Compare
Spencer-Comin
requested review from
Leonardo2718,
fjeremic,
0xdaryl,
aviansie-ben,
knn-k and
vijaysun-omr
as code owners
knn-k
approved these changes
May 1, 2024
knn-k
reviewed
May 1, 2024
Previously the arraycmp IL opcode's length child was specified as 32 bits but was inconsistent in its use. This commit changes the specification of the length child to 64 bits, and normalizes the use to 64 bits. Closes: eclipse-omr#6992 Signed-off-by: Spencer Comin <spencer.comin@ibm.com>
hzongaro
approved these changes
May 9, 2024
|
jenkins build all |
|
@Spencer-Comin In the last launched build there seems to be failures in riscv. Can you check? |
|
The riscv failure looks like an infra failure |
|
jenkins build all |
|
Launched build with riscv64 still failed with @IBMJimmyk / @zl-wang can we get your review for P changes as well ? |
|
I looked over the P changes inside |
|
Thanks @IBMJimmyk . @hzongaro / @0xdaryl I think this one is goof to merge. Can we request you to review/merge these changes ? |
|
Changes have been reviewed by people familiar with the code generation for the various platforms. Merging. |
This was referenced Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the arraycmp IL opcode's length child was specified as 32 bits but was inconsistent in its use. This commit changes the specification of the length child to 64 bits, and normalizes the use to 64 bits.
Closes: #6992