Fix max open file limits on OSX #5108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@genie-omr build all |
|
@genie-omr build all |
rwy7
force-pushed
the
fd-lim-osx
branch
3 times, most recently
from
f04c72f to
c332c87
Compare
|
@genie-omr build all |
|
Does this fix #4990? |
|
Yep, I just edited the top comment to reflect that fact. |
fjeremic
reviewed
Apr 23, 2020
There was a problem hiding this comment.
Thanks so much for fixing this! Suggesting @youngar / @keithc-ca to have another look as a port library experts.
keithc-ca
suggested changes
Apr 24, 2020
on OSX, there are two mechanisms for reporting the limits of the system. The first is getrlimit/setrlimit, and the second is through sysctl. Sysctl will report the maximum number of open files that the kernel will allow a process to have. This is a global property that affects all processes. getrlimit/setrlimit, on the other hand, will report the limits set on a given process. These two limits do not have to match. The true soft limit for open files is the minimum between the current rlimit and the sysctl limit. The true hard limit is the minimum between the max rlimit and the sysctl limit. With this PR, this is what we report and enforce on OSX. Signed-off-by: Robert Young <rwy0717@gmail.com>
|
I've addressed Keith's comments (thanks for the review!). |
|
I'll wait for an approval from either Keith or Andrew and this should be good to go. |
keithc-ca
approved these changes
Apr 24, 2020
fjeremic
approved these changes
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on OSX, there are two mechanisms for reporting the limits of the system.
The first is getrlimit/setrlimit, and the second is through sysctl.
Sysctl will report the maximum number of open files that the kernel will
allow a process to have. This is a global property that affects all
processes.
getrlimit/setrlimit, on the other hand, will report the limits set on a
given process.
These two limits do not have to match.
The true soft limit for open files is the minimum between the current
rlimit and the sysctl limit. The true hard limit is the minimum between
the max rlimit and the sysctl limit.
With this PR, this is what we report and enforce on OSX.
Fixes: #4990
Signed-off-by: Robert Young rwy0717@gmail.com