-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework MemoryReference::accessStaticItem in Power for JITServer #4442
Conversation
Depends on #4441 |
I wasn't able to use In an earlier conversation, @ymanton had mentioned that perhaps the |
This PR is part of the work in eclipse-openj9/openj9#6991 |
10680c7
to
de23b87
Compare
de23b87
to
d3f95fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not 100% confident about these changes. Do you recall which of these changes are actually needed for JITServer and which might have been changed pro-actively because of existing checks for compileRelocatableCode()
?
As I spoke to you earlier, pretty much all of these changes are consistent with the checks done in |
@ymanton There's still some work to be done here (mainly the following need a response from you: #4442 (comment), #4442 (comment)). Other than that I think I've addressed everything. So I'll wait for another round of review from you now. |
@ymanton Ready for another review. I've done a rebase as well to resolve the merge conflicts. |
This commit reorganizes this routine to broaden the scope of when relocatable code can be generated. We now use front end queries to determine when a relocatable instruction needs to be generated. This is needed in cases where we are doing a remote compile. Signed-off-by: Dhruv Chopra <Dhruv.C.Chopra@ibm.com>
Signed-off-by: Dhruv Chopra <Dhruv.C.Chopra@ibm.com>
In some situations, this query was being used in addition to another query that would also return the same answer. Since it doesn't make sense to use this query anymore (as the other one is more appropriate given the data type), this commit removes uses of such queries. Additionally, use of the new needRelocationsForCurrentMethodPC query is added for symbol->isCompiledMethod data types. Signed-off-by: Dhruv Chopra <Dhruv.C.Chopra@ibm.com>
c80bd8c
to
fa3a153
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@genie-omr build all |
X86 build failed with:
Doesn't look related to this PR. |
@genie-omr build x32linux |
In this PR we make the changes needed to use front end queries instead of
cg->compileRelocatableCode()
when deciding whether to generate relocatable code insideaccessStaticItem
. This allows us to generate relocatable code for remote compilations in a consumer project such as OpenJ9, because the appropriate front-end query can return the right answer depending on the mode of compilation.