Reduce default output of tracegen #3664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tools/tracegen/CFileWriter.cpp
Outdated
| @@ -45,7 +45,9 @@ CFileWriter::writeOutputFiles(J9TDFOptions *options, J9TDFFile *tdf, J9TDFGroup | |||
| time_t targetFileMtime = FileUtils::getMtime(fileName); | |||
|
|
|||
| if ((false == options->force) && (targetFileMtime > sourceFileMtime)) { | |||
| printf("C file is already up-to-date: %s\n", fileName); | |||
| if (true == options->verboseOutput) { | |||
There was a problem hiding this comment.
since the variable is a boolean can you remove the true == part?
There was a problem hiding this comment.
Fixed. There are also some cases I saw where false == options->force could be replaced with !options->force if we wanted to.
Make tracegen not output any information unless verbose is enabled. Signed-off-by: Andrew Young <youngar17@gmail.com>
|
@genie-omr build all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make tracegen not output any information unless verbose is enabled.
Signed-off-by: Andrew Young youngar17@gmail.com