Fix double initialization of MUTEX in OMRMonitor.cpp #3663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the Windows support was added, or maybe after some subsequent bad merge happened, it looks like a #if for the Windows platform was missed or removed from OMR::Monitor::init(), leaving a double call to MUTEX_INIT. This commit wraps the code in the proper conditional #if...#else...#endif analogous to similar code in the destroy(), enter(), and exit() functions. Signed-off-by: Mark Stoodley <mstoodle@ca.ibm.com>
fjeremic
approved these changes
Mar 13, 2019
|
@genie-omr build all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Windows support was added, or maybe after some subsequent
bad merge happened, it looks like a #if for the Windows platform
was missed or removed from OMR::Monitor::init(), leaving a double
call to MUTEX_INIT. This commit wraps the code in the proper
conditional #if...#else...#endif analogous to similar code in
the destroy(), enter(), and exit() functions.
Signed-off-by: Mark Stoodley mstoodle@ca.ibm.com