Change OmrTracegen message from a warning to a status #3652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old warning message was quite verbose, and not a real warning. By changing the message to status the output is less alarming. From: ``` CMake Warning at cmake/modules/OmrTracegen.cmake:32 (message): OMR: No trace root has been set. Defaulting to '/home/aryoung/wsp/omr/build' Call Stack (most recent call first): CMakeLists.txt:43 (include) ``` To: ``` -- OMR: No trace root has been set. Defaulting to '/home/aryoung/wsp/omr/build' ``` Signed-off-by: Andrew Young <youngar17@gmail.com>
|
The AppVeyor build uses CMake so no further testing is required |
charliegracie
approved these changes
Mar 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old warning message was quite verbose, and not a real warning. By
changing the message to status the output is less alarming.
From:
To:
Signed-off-by: Andrew Young youngar17@gmail.com