Remove call to VMJ9 traceAssumeFailure #3613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In J9, traceAssumeFailure has been disabled, so calling it has no effect. This is the only call site, so once it is removed, traceAssumeFailure can be removed from the J9 VM. Signed-off-by: Robert Young <rwy0717@gmail.com>
|
@genie-omr build all |
0xdaryl
approved these changes
Feb 26, 2019
|
zOS failure is infrastructural. LoZ tests pass. Merging. |
rwy7
added a commit
to rwy7/openj9
that referenced
this pull request
Apr 16, 2019
This function is disabled, and has no callsites in J9. In OMR, there is one remaining call inside the implemention of TR_ASSERT. Once this call is removed in eclipse-omr/omr#3613, this function can be deleted. Signed-off-by: Robert Young <rwy0717@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In J9, traceAssumeFailure has been disabled, so calling it has no
effect. This is the only call site, so once it is removed,
traceAssumeFailure can be removed from the J9 VM.
Signed-off-by: Robert Young rwy0717@gmail.com