Clean up c-style formatting #3599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwy7
requested review from
0xdaryl,
charliegracie,
fjeremic,
Leonardo2718 and
mstoodle
as code owners
Leonardo2718
suggested changes
Feb 22, 2019
rwy7
commented
Feb 22, 2019
rwy7
force-pushed
the
fix-format-strings
branch
2 times, most recently
from
8ac4fcc to
28c1d1a
Compare
|
@genie-omr build all |
| @@ -21,6 +21,7 @@ | |||
|
|
|||
There was a problem hiding this comment.
Copyright date needs to be updated.
There was a problem hiding this comment.
OK I might wait until CI passes, then push an amended commit that updates the copyrights, if that's OK?
There was a problem hiding this comment.
Sure, although the zos machines are down so it might be a while before that job passes.
This PR adds a new header, omrformatconsts.h. This header provides platform-independent format specifiers for the following data types: - int8_t / uint8_t - int16_t / uint16_t - int32_t / uint32_t - int64 / uint64_t - size_t - intptr_t / uintptr_t - ptrdiff_t The following formats are provided in this PR: - x: unsigned hexadecimal format - u: unsigned decimal format - d: signed decimal format Normally, there are either special macros defined by the C library, or special format characters in the case of size_t / ptrdiff_t. Unfortunately, because of poor standards compliance across our compilers, these aren't universally available. This PR defines portable string constants that can be used to contruct correct format strings. The names of the constants follow the convention of those normally provided by stdint.h. Signed-off-by: Robert Young <rwy0717@gmail.com>
Signed-off-by: Robert Young <rwy0717@gmail.com>
Signed-off-by: Robert Young <rwy0717@gmail.com>
Signed-off-by: Robert Young <rwy0717@gmail.com>
The PID is, wierdly enough, a 32bit signed integer on most platforms. Extend the PID type to a signed long, just in case there's a platform that actually uses 64 bit pids. Signed-off-by: Robert Young <rwy0717@gmail.com>
Signed-off-by: Robert Young <rwy0717@gmail.com>
rwy7
force-pushed
the
fix-format-strings
branch
from
28c1d1a to
f38f459
Compare
|
|
@genie-omr build all |
|
@genie-omr build zos |
|
Alright, the zos build is failing because of infrastructural problems. These changes are not z specific and all the other builds (including zlinux) passed. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new header,
omrformatconsts.h, which defines a set of portable constants for building format strings for special integral types. This header provides platform-independent format specifiers for the following data types:The following formats are provided in this PR:
(notably missing: i)
Normally, there are either special macros defined by the C library, or
special format characters in the case of size_t / ptrdiff_t.
Unfortunately, because of poor standards compliance across our
compilers, these aren't universally available.
The names of the constants follow the convention of those normally
provided by stdint.h.
As well, I've gone through and fixed a number of locations with format strings that generate errors.