Improve assertion output for large object stats #3589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitripivkine
requested review from
charliegracie and
youngar
as code owners
Log() calculation can be broken in OS or output of the function might be corrupted. This change improves assertions output. Signed-off-by: Dmitri Pivkine <Dmitri_Pivkine@ca.ibm.com>
dmitripivkine
force-pushed
the
master
branch
from
a660dea to
1dd5a5a
Compare
|
@amicic Would you please review? |
amicic
approved these changes
Feb 20, 2019
|
@genie-omr build all |
charliegracie
approved these changes
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log() calculation can be broken in OS or output of the function might be
corrupted. This change improves assertions output.
Signed-off-by: Dmitri Pivkine Dmitri_Pivkine@ca.ibm.com