Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in specifying cmake source dir #3560

Merged
merged 1 commit into from
Feb 12, 2019

Conversation

rwy7
Copy link
Contributor

@rwy7 rwy7 commented Feb 12, 2019

As of cmake 13.3, users must specify a source directory. Due to an old
typo in the appvyeyor config, the source directory "./" was attached to
the end of the cache name.

This PR adds back the missing space between the initial cache file and
the source directory.

Fixes: #3559

Signed-off-by: Robert Young rwy0717@gmail.com

Copy link
Contributor

@Leonardo2718 Leonardo2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Leonardo2718 Leonardo2718 self-assigned this Feb 12, 2019
@fjeremic
Copy link
Contributor

fjeremic commented Feb 12, 2019

The prefixes in the PR titles/commits are not very useful given that we tag the PRs anyway with the ci label. Furthermore the commit message could use some loving [1] [2]:

The first line describes the change made. It is written in the imperative mood, and should say what happens when the patch is applied. Keep it short and simple. The first line should be less than 70 characters, where reasonable, and should be written in sentence case preferably not ending in a period. Leave a blank line between the first line and the message body.

[1] https://github.com/eclipse/omr/blob/master/CONTRIBUTING.md#commit-guidelines
[2] https://chris.beams.io/posts/git-commit/

As of cmake 13.3, users must specify a source directory. Due to an old
typo in the appvyeyor config, the source directory "./" was attached to
the end of the cache name.

This PR adds back the missing space between the initial cache file and
the source directory.

Signed-off-by: Robert Young <rwy0717@gmail.com>
@rwy7 rwy7 changed the title ci: fix typo in specifying cmake source dir Fix typo in specifying cmake source dir Feb 12, 2019
@Leonardo2718
Copy link
Contributor

AppVeyor build passed previously and changes to the commit did not affect the change itself. The change only impacts AppVeyor so no further testing is required. Merging.

@Leonardo2718 Leonardo2718 merged commit 1010c5f into eclipse-omr:master Feb 12, 2019
@rwy7 rwy7 deleted the fix-appveyor branch February 12, 2019 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants