Make the Port Library a comptest dependency #3550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leonardo2718
changed the title
|
Making WIP while I consider a few other things. |
0xdaryl
reviewed
Feb 7, 2019
Signed-off-by: Leonardo Banderali <leonardo2718@protonmail.com>
The JitTest test fixture now has a static field intended to "hold" the port library object. Two static member function are also added to the class to initialize and shutdown the library. These are called from the SetUp() and TearDown() methods of a global gtest environment. One use case for having the port library available in Tril-based tests is to skip tests conditionally. For example, using the following line would cause a test to be skipped if it is executed on x86 and some variable `foo` is 0: SKIP_IF(OMRPORT_ARCH_X86 == omrsysinfo_get_CPU_architecture() && 0 == foo); Signed-off-by: Leonardo Banderali <leonardo2718@protonmail.com>
Leonardo2718
force-pushed
the
testskip
branch
from
8a4841d to
9472fd9
Compare
|
@genie-omr build all |
Leonardo2718
changed the title
|
Un-WIPed. |
|
AppVeyor build failed because of infra problems. Restarted. |
0xdaryl
approved these changes
Feb 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JitTest test fixture now has a static field intended to "hold" the
port library object. Two static member function are also added to the
class to initialize and shutdown the library. These are called from
the SetUp() and TearDown() methods of a global gtest environment.
One use case for having the port library available in Tril-based tests
is to skip tests conditionally. For example, using the following line
would cause a test to be skipped if it is executed on x86 and some
variable
foois 0:SKIP_IF(OMRPORT_ARCH_X86 == omrsysinfo_get_CPU_architecture() && 0 == foo);