Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc. CodeCacheManager readability improvements #3546

Merged
merged 1 commit into from
Feb 6, 2019

Conversation

0xdaryl
Copy link
Contributor

@0xdaryl 0xdaryl commented Feb 5, 2019

  • Use 'usingRepository' queries to improve code readability
  • Rename getNewCacheMemorySegment to the more meaningful
    getNewCodeCacheMemorySegment

Signed-off-by: Daryl Maier maier@ca.ibm.com

* Use 'usingRepository' queries to improve code readability
* Rename `getNewCacheMemorySegment` to the more meaningful
  `getNewCodeCacheMemorySegment`

Signed-off-by: Daryl Maier <maier@ca.ibm.com>
@0xdaryl
Copy link
Contributor Author

0xdaryl commented Feb 5, 2019

@genie-omr build all

Copy link
Contributor

@Leonardo2718 Leonardo2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Leonardo2718 Leonardo2718 self-assigned this Feb 5, 2019
@Leonardo2718 Leonardo2718 merged commit 0d3d4c1 into eclipse-omr:master Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants