Misc. CodeCacheManager API refactoring #3542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
0xdaryl
commented
Feb 4, 2019
0xdaryl
commented
- Relocate CodeCache::allocate function to CodeCacheManager
- Delete unused functionality from CodeCacheManager
- Remove reservationInterfaceCache from CodeCacheManager
|
@genie-omr build all |
Leonardo2718
reviewed
Feb 4, 2019
The `CodeCache::allocate()` function simply called back to the CodeCacheManager to accomplish nearly all of its operations (except reserving a newly added CodeCache). It makes more sense for the CodeCacheManager to own and perform this functionality. Give the function a more descriptive name (`allocateCodeCacheFromNewSegment`) and provide some API documentation. Re-route the current `CodeCache::allocate()` function to call the CodeCacheManager version while downstream projects are changed. Signed-off-by: Daryl Maier <maier@ca.ibm.com>
`dumpCodeCaches()` and empty enum `ErrorCode` are not used in OMR nor any known downstream projects. Signed-off-by: Daryl Maier <maier@ca.ibm.com>
Function has been relocated to OpenJ9. Signed-off-by: Daryl Maier <maier@ca.ibm.com>
|
@genie-omr build all (for good measure) |
|
AppVeyor build failed because of infra problems. Restarted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.