Dont crash when seeing invalid tree while tracing #3537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xdaryl
reviewed
Jan 31, 2019
compiler/ras/Tree.cpp
Outdated
| output.append(" on %s%dn", globalIndexPrefix.getStr(), node->getNullCheckReference()->getGlobalIndex()); | ||
| if (node->getNullCheckReference()) | ||
| output.append(" on %s%dn", globalIndexPrefix.getStr(), node->getNullCheckReference()->getGlobalIndex()); | ||
| else output.append(" on null NullCheckReference ----- INVALID tree!!\n"); |
There was a problem hiding this comment.
From a consistency POV, this message ends with a newline but all others in a similar context don't. Arguably, trying to print an invalid tree is breaking the mold, but can you confirm that the newline is what you want here?
There was a problem hiding this comment.
Thanks for pointing that out. I removed the newline.
When seeing NULLChk without NULLChkReference while printing trees to tracing log, we should try to continue printing the complete trees which makes debugging easier. Signed-off-by: Yi Zhang <yizhang@ca.ibm.com>
|
@genie-omr build all |
0xdaryl
approved these changes
Jan 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When seeing NULLChk without NULLChkReference while printing trees
to tracing log, we should try to continue printing the complete
trees which makes debugging easier.
Signed-off-by: Yi Zhang yizhang@ca.ibm.com