Add rdbar handling in NullChk evaluator #3524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullChk's special case in compressed pointers where the node to be null checked is not the iiload but its child (ex. an aload) will now also handle the case where the child is rdbad node. Signed-off-by: Dhruv Chopra <Dhruv.C.Chopra@ibm.com>
dchopra001
changed the title
fjeremic
approved these changes
Jan 30, 2019
There was a problem hiding this comment.
This code really belongs in OpenJ9. I see the x86 implementation already exists there. @dchopra001 could you open up a beginner issues to migrate this code on all codegens to OpenJ9?
|
@genie-omr build all |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NullChk's special case in compressed pointers mode where the node to be null checked is not the iiload but its child (ex. an aload) will now also handle the case where the parent is a rdbar node.
Signed-off-by: Dhruv Chopra Dhruv.C.Chopra@ibm.com