S390: Fix type of FPC register #3509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infoForControl() and infoForControl_ceehdlr() were incorrectly returning OMRPORT_SIG_VALUE_ADDRESS instead of OMRPORT_SIG_VALUE_32 Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
|
@sehirst Can you review this please? |
|
@genie-omr build zos |
sehirst
approved these changes
Jan 24, 2019
|
LGTM - thanks! |
|
FYI @keithc-ca @sehirst the above OpenJ9 issue that was raised is almost certainly a result of this PR. I've posted investigation details and require your help to proceed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the S/390 architecture, the FPC register is 32-bits wide independent of whether a process is running in 31-bit or 64-bit mode.
infoForControl()andinfoForControl_ceehdlr()were incorrectlyreturning
OMRPORT_SIG_VALUE_ADDRESSinstead ofOMRPORT_SIG_VALUE_32.