Bound Tenure Expand #3495
Merged
Bound Tenure Expand #3495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amicic
requested review from
charliegracie,
mstoodle and
youngar
as code owners
amicic
force-pushed
the
bound_tenure_noCM
branch
from
66c5e33 to
601dc08
Compare
amicic
force-pushed
the
bound_tenure_noCM
branch
from
601dc08 to
bf30deb
Compare
|
@genie-omr build all |
|
@dmitripivkine can you review this as well please? |
amicic
force-pushed
the
bound_tenure_noCM
branch
from
bf30deb to
86487f7
Compare
|
added a couple of trace points |
gc/base/standard/Scavenger.cpp
Outdated
| uintptr_t soaFreeMemorySize = _extensions->heap->getApproximateActiveFreeMemorySize(MEMORY_TYPE_OLD) - _extensions->heap->getApproximateActiveFreeLOAMemorySize(MEMORY_TYPE_OLD); | ||
|
|
||
| /* We suspect that next scavegne will cause Tenure expansion, while Tenure free ratio is (was) already high enough */ | ||
| if ((scavengerGCStats->_avgTenureBytes > soaFreeMemorySize) && (_extensions->freeOldHeapSizeOnLastGlobalGC > (_extensions->oldHeapSizeOnLastGlobalGC * midTenureFreeRatio))) { |
There was a problem hiding this comment.
there is some weird spacing on this line
|
@genie-omr build all |
amicic
commented
Feb 4, 2019
gc/base/GCExtensionsBase.hpp
Outdated
| @@ -1419,7 +1426,6 @@ class MM_GCExtensionsBase : public MM_BaseVirtual { | |||
| , concurrentScavenger(false) | |||
| , concurrentScavengerForced(false) | |||
| , concurrentScavengerHWSupport(false) | |||
| , concurrentScavengerBackgroundThreads(1) | |||
There was a problem hiding this comment.
just noticed that I mistakenly removed a line here. must fix this first
amicic
force-pushed
the
bound_tenure_noCM
branch
from
86487f7 to
d4d9756
Compare
Fixing issue in eclipse-omr#3492 When running Gencon with Concurrent Mark disabled, prevent the unbounded growth of Tenure space. Two new percolate reasons are introduced: - if Tenure free heap was already high (at least midway between min and max bounds) in previous global GC, and it's suspected that Scavenge will expand Tenure even more (due to low current Tenure free, and based on historic tenuring activity) start global GC instead - if Tenure free heap was not very high in previous GC, we'll allow Scavenges and Tenure expansion, but we will break the streak when hitting the max free bound, and start global GC Signed-off-by: Aleksandar Micic <amicic@ca.ibm.com>
amicic
force-pushed
the
bound_tenure_noCM
branch
from
d4d9756 to
8648c0d
Compare
|
@genie-omr build all |
charliegracie
approved these changes
Feb 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing issue in #3492
When running Gencon with Concurrent Mark disabled, prevent the unbounded
growth of Tenure space.
Two new percolate reasons are introduced:
max bounds) in previous global GC, and it's suspected that Scavenge will
expand Tenure even more (due to low current Tenure free, and based on
historic tenuring activity) start global GC instead
Scavenges and Tenure expansion, but we will break the streak when
hitting the max free bound, and start global GC
Signed-off-by: Aleksandar Micic amicic@ca.ibm.com