Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated J9 snippets on X86 [Phase 2/2] #3472

Merged
merged 1 commit into from
Mar 21, 2019

Conversation

0dvictor
Copy link
Contributor

Follow-up of #3190, deprecated J9 snippets are removed.

Signed-off-by: Victor Ding dvictor@ca.ibm.com

@0dvictor 0dvictor changed the title Remove deprecated J9 snippets on X86 [Phase 2/2] WIP: Remove deprecated J9 snippets on X86 [Phase 2/2] Jan 16, 2019
@vijaysun-omr vijaysun-omr self-assigned this Jan 22, 2019
@0dvictor 0dvictor changed the title WIP: Remove deprecated J9 snippets on X86 [Phase 2/2] Remove deprecated J9 snippets on X86 [Phase 2/2] Feb 4, 2019
@0dvictor
Copy link
Contributor Author

0dvictor commented Feb 4, 2019

The dependent OpenJ9 change has been merged, this pull request is ready to go.

@Leonardo2718
Copy link
Contributor

@genie-omr build all

AppVeyor build failed because of infra problems so I restarted it.

@andrewcraik
Copy link
Contributor

LGTM from me

@vijaysun-omr
Copy link
Contributor

@0dvictor could you please fix the merge conflict in this PR ?

Follow-up of eclipse-omr#3190, deprecated J9 snippets are removed.

Signed-off-by: Victor Ding <dvictor@ca.ibm.com>
@0dvictor
Copy link
Contributor Author

Conflicts have been resolved.

@vijaysun-omr
Copy link
Contributor

@genie-omr build all

@vijaysun-omr vijaysun-omr merged commit 4b0cfe9 into eclipse-omr:master Mar 21, 2019
@0dvictor 0dvictor deleted the snippet branch March 21, 2019 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants