AArch64: Implement FP type conversion evaluators #3325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knn-k
changed the title
0xdaryl
requested review from
charliegracie,
fjeremic,
Leonardo2718,
vijaysun-omr and
youngar
as code owners
|
Updated files resolving merge conflicts. |
knn-k
force-pushed
the
aarch64eval21
branch
2 times, most recently
from
75a641b to
3ee63b4
Compare
This was referenced Dec 18, 2018
|
Hmm. Somehow a review was requested (presumably by me) on this one from many people. I'm not sure how that happened. As always, please feel free to comment if you wish, but I didn't intend to solicit any reviews. |
|
Resolved merge conflicts with #3378. |
0xdaryl
requested changes
Jan 30, 2019
| @@ -257,54 +257,71 @@ OMR::ARM64::TreeEvaluator::dnegEvaluator(TR::Node *node, TR::CodeGenerator *cg) | |||
| return OMR::ARM64::TreeEvaluator::unImpOpEvaluator(node, cg); | |||
| } | |||
|
|
|||
| static TR::Register * | |||
| intFpTypeCoversionHelper(TR::Node *node, TR::InstOpCode::Mnemonic op, TR::CodeGenerator *cg) | |||
There was a problem hiding this comment.
Could you fix the spelling of "Conversion" please, and then fix up the calls throughout?
This commit implements type conversion evaluators of floating-point types, such as i2f, d2l, and f2d. Signed-off-by: knn-k <konno@jp.ibm.com>
|
Updated files reflecting the review comment. |
|
@genie-omr build aarch64 This is an AArch64-specific change. A full genie build is not required. |
0xdaryl
approved these changes
Jan 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements type conversion evaluators of floating-point
types, such as i2f, d2l, and f2d.
Signed-off-by: knn-k konno@jp.ibm.com