Fix testMemoryInfo failure on OS X #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The available swap space can be obtained directly from the sysctl vm.swapusage call that is already being made. There is no need to probe the file system. Signed-off-by: Ronald Servant <ronald_servant@ca.ibm.com>
|
Running this commit through our test cluster. |
alin00
added a commit
that referenced
this pull request
Mar 14, 2016
Fix testMemoryInfo failure on OS X
janvrany
pushed a commit
to shingarov/omr
that referenced
this pull request
Mar 27, 2019
Fix file handle leak in isRunningInContainer() function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'make test' fails on OSX on my macbook pro.
[ FAILED ] 1 test, listed below:
[ FAILED ] PortSysinfoTest.sysinfo_testMemoryInfo
This test has passed on OS X machines with no swap space configured.
The failure is caused by the available swap space being detected as higher than the total swap space.
The attached commit simplifies the call to obtain the available swap space on OS X resulting in a value that is smaller than the total space available, allowing the test to pass.