Migrate to JUnit 5 tests #1358
Merged
Migrate to JUnit 5 tests #1358
+757
−733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 0.6.12
Signed-off-by: Aurélien Pupier <apupier@redhat.com>
Signed-off-by: Aurélien Pupier <apupier@redhat.com>
Signed-off-by: Aurélien Pupier <apupier@redhat.com>
Signed-off-by: system24seven <david@system24seven.com>
Signed-off-by: system24seven <david@system24seven.com>
# Conflicts: # README.md # build-tools/pom.xml # milo-examples/client-examples/pom.xml # milo-examples/pom.xml # milo-examples/server-examples/pom.xml # opc-ua-sdk/dictionary-manager/pom.xml # opc-ua-sdk/dictionary-reader/pom.xml # opc-ua-sdk/dictionary-reader/src/test/java/org/eclipse/milo/opcua/sdk/client/dtd/DataTypeDictionaryReaderTest.java # opc-ua-sdk/integration-tests/pom.xml # opc-ua-sdk/integration-tests/src/test/java/org/eclipse/milo/opcua/sdk/client/AddressSpaceTest.java # opc-ua-sdk/integration-tests/src/test/java/org/eclipse/milo/opcua/sdk/client/UaNodeTest.java # opc-ua-sdk/integration-tests/src/test/java/org/eclipse/milo/opcua/sdk/client/UaObjectNodeTest.java # opc-ua-sdk/integration-tests/src/test/java/org/eclipse/milo/opcua/sdk/client/UaVariableNodeTest.java # opc-ua-sdk/integration-tests/src/test/java/org/eclipse/milo/opcua/sdk/client/methods/UaMethodTest.java # opc-ua-sdk/integration-tests/src/test/java/org/eclipse/milo/opcua/sdk/client/subscriptions/AbstractManagedItemTest.java # opc-ua-sdk/integration-tests/src/test/java/org/eclipse/milo/opcua/sdk/client/subscriptions/BatchModifyMonitoredItemsTest.java # opc-ua-sdk/integration-tests/src/test/java/org/eclipse/milo/opcua/sdk/client/subscriptions/BatchSetMonitoringModeTest.java # opc-ua-sdk/integration-tests/src/test/java/org/eclipse/milo/opcua/sdk/client/subscriptions/ManagedDataItemTest.java # opc-ua-sdk/integration-tests/src/test/java/org/eclipse/milo/opcua/sdk/client/subscriptions/ManagedEventItemTest.java # opc-ua-sdk/integration-tests/src/test/java/org/eclipse/milo/opcua/sdk/client/subscriptions/ManagedSubscriptionTest.java # opc-ua-sdk/integration-tests/src/test/java/org/eclipse/milo/opcua/sdk/core/DataTypeTreeTest.java # opc-ua-sdk/integration-tests/src/test/java/org/eclipse/milo/opcua/sdk/server/api/methods/AbstractMethodInvocationHandlerTest.java # opc-ua-sdk/integration-tests/src/test/java/org/eclipse/milo/opcua/sdk/server/api/util/AttributeWriterTest.java # opc-ua-sdk/pom.xml # opc-ua-sdk/sdk-client/pom.xml # opc-ua-sdk/sdk-core/pom.xml # opc-ua-sdk/sdk-core/src/test/java/org/eclipse/milo/opcua/sdk/server/util/GroupMapCollateTest.java # opc-ua-sdk/sdk-server/pom.xml # opc-ua-sdk/sdk-server/src/main/java/org/eclipse/milo/opcua/sdk/server/util/AttributeWriter.java # opc-ua-sdk/sdk-server/src/test/java/org/eclipse/milo/opcua/sdk/core/AccessLevelTest.java # opc-ua-sdk/sdk-server/src/test/java/org/eclipse/milo/opcua/sdk/core/CefactEngineeringUnitsTest.java # opc-ua-sdk/sdk-server/src/test/java/org/eclipse/milo/opcua/sdk/core/NumericRangeTest.java # opc-ua-sdk/sdk-server/src/test/java/org/eclipse/milo/opcua/sdk/core/ReferenceTest.java # opc-ua-sdk/sdk-server/src/test/java/org/eclipse/milo/opcua/sdk/server/LifecycleManagerTest.java # opc-ua-sdk/sdk-server/src/test/java/org/eclipse/milo/opcua/sdk/server/api/config/OpcUaServerConfigTest.java # opc-ua-sdk/sdk-server/src/test/java/org/eclipse/milo/opcua/sdk/server/events/conversions/AbstractConversionTest.java # opc-ua-sdk/sdk-server/src/test/java/org/eclipse/milo/opcua/sdk/server/events/conversions/BooleanConversionsTest.java # opc-ua-sdk/sdk-server/src/test/java/org/eclipse/milo/opcua/sdk/server/events/conversions/ByteConversionsTest.java # opc-ua-sdk/sdk-server/src/test/java/org/eclipse/milo/opcua/sdk/server/events/conversions/ByteStringConversionsTest.java # opc-ua-sdk/sdk-server/src/test/java/org/eclipse/milo/opcua/sdk/server/events/conversions/DateTimeConversionsTest.java # opc-ua-sdk/sdk-server/src/test/java/org/eclipse/milo/opcua/sdk/server/events/conversions/ExpandedNodeIdConversionsTest.java # opc-ua-sdk/sdk-server/src/test/java/org/eclipse/milo/opcua/sdk/server/events/conversions/GuidConversionsTest.java # opc-ua-sdk/sdk-server/src/test/java/org/eclipse/milo/opcua/sdk/server/events/conversions/LocalizedTextConversionsTest.java # opc-ua-sdk/sdk-server/src/test/java/org/eclipse/milo/opcua/sdk/server/events/conversions/NodeIdConversionsTest.java # opc-ua-sdk/sdk-server/src/test/java/org/eclipse/milo/opcua/sdk/server/events/conversions/QualifiedNameConversionsTest.java # opc-ua-sdk/sdk-server/src/test/java/org/eclipse/milo/opcua/sdk/server/events/operators/EqualsTest.java # opc-ua-sdk/sdk-server/src/test/java/org/eclipse/milo/opcua/sdk/server/events/operators/IsNullTest.java # opc-ua-sdk/sdk-server/src/test/java/org/eclipse/milo/opcua/sdk/server/nodes/UaNodeTest.java # opc-ua-sdk/sdk-server/src/test/java/org/eclipse/milo/opcua/sdk/server/nodes/delegates/AttributeDelegateChainTest.java # opc-ua-sdk/sdk-server/src/test/java/org/eclipse/milo/opcua/sdk/server/nodes/factories/InstanceDeclarationHierarchyTest.java # opc-ua-sdk/sdk-server/src/test/java/org/eclipse/milo/opcua/sdk/server/nodes/factories/NodeFactoryTest.java # opc-ua-sdk/sdk-server/src/test/java/org/eclipse/milo/opcua/sdk/server/nodes/filters/AttributeFilterChainTest.java # opc-ua-sdk/sdk-server/src/test/java/org/eclipse/milo/opcua/sdk/server/util/HostnameUtilTest.java # opc-ua-sdk/sdk-tests/pom.xml # opc-ua-sdk/sdk-tests/src/test/java/org/eclipse/milo/opcua/sdk/client/api/identity/AnonymousProviderTest.java # opc-ua-sdk/sdk-tests/src/test/java/org/eclipse/milo/opcua/sdk/client/config/OpcUaClientConfigTest.java # opc-ua-sdk/sdk-tests/src/test/java/org/eclipse/milo/opcua/sdk/client/session/SessionFsmTest.java # opc-ua-sdk/sdk-tests/src/test/java/org/eclipse/milo/opcua/sdk/client/subscriptions/ClientHandleSequenceTest.java # opc-ua-stack/bsd-core/pom.xml # opc-ua-stack/bsd-generator/pom.xml # opc-ua-stack/bsd-parser-gson/pom.xml # opc-ua-stack/bsd-parser-gson/src/test/java/org/eclipse/milo/opcua/binaryschema/gson/JsonBsdParserTest.java # opc-ua-stack/bsd-parser/pom.xml # opc-ua-stack/bsd-parser/src/test/java/org/eclipse/milo/opcua/binaryschema/BsdParserTest.java # opc-ua-stack/bsd-parser/src/test/java/org/eclipse/milo/opcua/binaryschema/GenericBsdParserTest.java # opc-ua-stack/pom.xml # opc-ua-stack/stack-client/pom.xml # opc-ua-stack/stack-core/pom.xml # opc-ua-stack/stack-core/src/test/java/org/eclipse/milo/opcua/stack/SequenceHeaderTest.java # opc-ua-stack/stack-core/src/test/java/org/eclipse/milo/opcua/stack/SerializationFixture2.java # opc-ua-stack/stack-core/src/test/java/org/eclipse/milo/opcua/stack/SymmetricSecurityHeaderTest.java # opc-ua-stack/stack-core/src/test/java/org/eclipse/milo/opcua/stack/core/AttributeIdTest.java # opc-ua-stack/stack-core/src/test/java/org/eclipse/milo/opcua/stack/core/channel/messages/HelloMessageTest.java # opc-ua-stack/stack-core/src/test/java/org/eclipse/milo/opcua/stack/core/security/DefaultCertificateManagerTest.java # opc-ua-stack/stack-core/src/test/java/org/eclipse/milo/opcua/stack/core/security/DefaultTrustListManagerTest.java # opc-ua-stack/stack-core/src/test/java/org/eclipse/milo/opcua/stack/core/serialization/OpcUaBinaryStreamDecoderTest.java # opc-ua-stack/stack-core/src/test/java/org/eclipse/milo/opcua/stack/core/serialization/OpcUaXmlStreamDecoderTest.java # opc-ua-stack/stack-core/src/test/java/org/eclipse/milo/opcua/stack/core/serialization/binary/BinaryDecoderTest.java # opc-ua-stack/stack-core/src/test/java/org/eclipse/milo/opcua/stack/core/serialization/binary/BinarySerializationFixture.java # opc-ua-stack/stack-core/src/test/java/org/eclipse/milo/opcua/stack/core/serialization/binary/DataValueSerializationTest.java # opc-ua-stack/stack-core/src/test/java/org/eclipse/milo/opcua/stack/core/serialization/binary/DiagnosticInfoSerializationTest.java # opc-ua-stack/stack-core/src/test/java/org/eclipse/milo/opcua/stack/core/serialization/binary/ExpandedNodeIdSerializationTest.java # opc-ua-stack/stack-core/src/test/java/org/eclipse/milo/opcua/stack/core/serialization/binary/ExtensionObjectSerializationTest.java # opc-ua-stack/stack-core/src/test/java/org/eclipse/milo/opcua/stack/core/serialization/binary/GuidSerializationTest.java # opc-ua-stack/stack-core/src/test/java/org/eclipse/milo/opcua/stack/core/serialization/binary/LocalizedTextSerializationTest.java # opc-ua-stack/stack-core/src/test/java/org/eclipse/milo/opcua/stack/core/serialization/binary/NodeIdSerializationTest.java # opc-ua-stack/stack-core/src/test/java/org/eclipse/milo/opcua/stack/core/serialization/binary/OpcUaBinaryStreamEncoderTest.java # opc-ua-stack/stack-core/src/test/java/org/eclipse/milo/opcua/stack/core/serialization/binary/StringSerializationTest.java # opc-ua-stack/stack-core/src/test/java/org/eclipse/milo/opcua/stack/core/serialization/binary/VariantSerializationTest.java # opc-ua-stack/stack-core/src/test/java/org/eclipse/milo/opcua/stack/core/serialization/binary/XmlElementSerializationTest.java # opc-ua-stack/stack-core/src/test/java/org/eclipse/milo/opcua/stack/core/types/builtin/ByteStringTest.java # opc-ua-stack/stack-core/src/test/java/org/eclipse/milo/opcua/stack/core/types/builtin/DateTimeTest.java # opc-ua-stack/stack-core/src/test/java/org/eclipse/milo/opcua/stack/core/types/builtin/ExpandedNodeIdTest.java # opc-ua-stack/stack-core/src/test/java/org/eclipse/milo/opcua/stack/core/types/builtin/NodeIdTest.java # opc-ua-stack/stack-core/src/test/java/org/eclipse/milo/opcua/stack/core/types/builtin/QualifiedNameTest.java # opc-ua-stack/stack-core/src/test/java/org/eclipse/milo/opcua/stack/core/types/builtin/VariantTest.java # opc-ua-stack/stack-core/src/test/java/org/eclipse/milo/opcua/stack/core/types/structured/ApplicationDescriptionTest.java # opc-ua-stack/stack-core/src/test/java/org/eclipse/milo/opcua/stack/core/util/ArrayUtilTest.java # opc-ua-stack/stack-core/src/test/java/org/eclipse/milo/opcua/stack/core/util/CertificateUtilTest.java # opc-ua-stack/stack-core/src/test/java/org/eclipse/milo/opcua/stack/core/util/EndpointUtilTest.java # opc-ua-stack/stack-core/src/test/java/org/eclipse/milo/opcua/stack/core/util/ExecutionQueueTest.java # opc-ua-stack/stack-core/src/test/java/org/eclipse/milo/opcua/stack/core/util/LazyTest.java # opc-ua-stack/stack-core/src/test/java/org/eclipse/milo/opcua/stack/core/util/NonceUtilTest.java # opc-ua-stack/stack-core/src/test/java/org/eclipse/milo/opcua/stack/core/util/validation/CertificateValidationUtilTest.java # opc-ua-stack/stack-server/pom.xml # opc-ua-stack/stack-tests/pom.xml # opc-ua-stack/stack-tests/src/test/java/org/eclipse/milo/opcua/stack/ChunkSerializationTest.java # opc-ua-stack/stack-tests/src/test/java/org/eclipse/milo/opcua/stack/ClientCertificateValidatorIT.java # opc-ua-stack/stack-tests/src/test/java/org/eclipse/milo/opcua/stack/ClientServerTest.java # opc-ua-stack/stack-tests/src/test/java/org/eclipse/milo/opcua/stack/SecurityFixture.java # opc-ua-stack/stack-tests/src/test/java/org/eclipse/milo/opcua/stack/StackIntegrationTest.java # opc-ua-stack/stack-tests/src/test/java/org/eclipse/milo/opcua/stack/client/config/UaStackClientConfigTest.java # opc-ua-stack/stack-tests/src/test/java/org/eclipse/milo/opcua/stack/server/EndpointConfigurationTest.java # pom.xml
…migrateToJunitTest
Signed-off-by: system24seven <david@system24seven.com>
Signed-off-by: system24seven <david@system24seven.com>
|
Can one of the admins verify this patch? |
10 tasks
|
Thank you. I fixed some formatting and broken tests, but there's still more to fix. I'll work on this a bit today. |
|
This still needs another review pass, I think there's still a lot of "expected" vs "actual" parameters being passed to the assertions in the wrong position. |
Signed-off-by: system24seven <david@system24seven.com>
Signed-off-by: system24seven <david@system24seven.com>
Signed-off-by: system24seven <david@system24seven.com>
Signed-off-by: system24seven <david@system24seven.com>
|
I am pretty sure I have got the assertions correct, there are a couple where you are comparing two expected values that I have left alone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All tests are changed to match JUnit 5, and all testNG references are removed.
Two tests are failing for unknown reasons, @kevinherron you were last working on the BinaryDecoderTest.testEnumArray and CertificateValidationUtilTest.testBuildAndValidate_LeafIntermediateSigned_Revoked from what I can see.
Before you submit a pull request please acknowledge the following:
See CONTRIBUTING for more information.