Import m2e-apt #579
Merged
Import m2e-apt #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This initial commit is a standalone version of Karl M. Davis' patch for m2e bug #335036 Support for annotation processing (https://bugs.eclipse.org/bugs/show_bug.cgi?id=335036) Since we can't use the org.eclipse namespace in this release, the package names and namespace have been renamed to org.jboss.tools.maven.apt. The m2e-apt project can now produce a standalone eclipse update site containing annotation processing support for m2e. Test are not included in this initial commit. This commit is a bit larger than Karl's initial patch, but the additions are insignificant compared to Karl's work. That's why he's the author of this commit. Fred Bricon - JBoss by Red Hat Signed-off-by: Fred Bricon <fbricon@gmail.com>
Signed-off-by: Fred Bricon <fbricon@gmail.com>
Signed-off-by: Fred Bricon <fbricon@gmail.com>
…ry path Signed-off-by: Fred Bricon <fbricon@gmail.com>
A complete refactoring was undertaken to provide support for org.bsc.maven:maven-processor-plugin : - all classes were moved to an internal package as we can not guarantee a public API at this point. - plugin dependencies are added to the factory path - compile AND runtime dependencies are searched for / added to the factory path - java nature is added if missing, as the APT configuration is triggered before the Java one, it needs to work with a Java project. - unused code was removed (mostly marker management). Signed-off-by: Fred Bricon <fbricon@gmail.com>
Attempt to parse out annotation processor arguments from the compilerArgument element of the maven compiler plugin. The compilerArgument string is parsed looking for strings that match the form -Akey[=value] N.B. This method was cherry-picked from jbosstools/m2e-apt#1 - Fred Signed-off-by: Fred Bricon <fbricon@gmail.com>
Signed-off-by: Fred Bricon <fbricon@gmail.com>
Current commit contains "basic" UI to manage m2e-apt preferences. Some classes where copied from JDT around PropertyAndPreferencePage (copied to org.jboss.tools.maven.apt.ui.preferences.xpl). These classes will probably be refactored / deleted in the (near) future. Since I'm not too familiar with the Preferences API, Preferences Management implementation is rather naive, there's certainly room in for improvements in that area. Signed-off-by: Fred Bricon <fbricon@gmail.com>
Signed-off-by: Fred Bricon <fbricon@gmail.com>
New complete refactoring to enable support for different annotation processing strategies (I basically broke everything): - New mode maven_execution corresponds to executing maven-processor-plugin as a build participant (code from https://github.com/excilys/m2e-extras/blob/40502d278f26a6beae07bcbed6ba7eed0a9226a6/com.excilys.ebi.m2e.apt/src/main/java/com/excilys/ebi/m2e/apt/internal/AptBuildParticipant.java) - For some reason, executing maven-compiler-plugin with proc:only as part of a Build participant didn't pan out. That means the maven_execution mode is downgraded (or promoted?) to jdt_apt for maven-compiler-plugin - Generated source folders are automatically created in maven_execution mode (if annotation processing is detected) so the folders can be added to the project's classpath (no need to add some build-helper-maven-plugin configuration) Signed-off-by: Fred Bricon <fbricon@gmail.com>
Signed-off-by: Fred Bricon <fbricon@gmail.com>
Fixed typo in Excilys name
…ools.maven.apt.ui/plugin.properties; tweak build.properties for apt.ui plugin; tweak plugin.properties for apt.core plugin
…r and bundle-localization)
updated patch to fix missing vendor and name for apt.ui and apt.core; also adjusts copyright dates/holders.
…ssorConfiguration() Signed-off-by: Fred Bricon <fbricon@gmail.com>
Signed-off-by: Fred Bricon <fbricon@gmail.com>
Turns out, adding all classpath dependency to the factory path is probably too aggressive. Until we can resolve that, m2e-apt is disabled by default. Related issue : https://issues.jboss.org/browse/JBIDE-12087 Signed-off-by: Fred Bricon <fbricon@gmail.com>
Signed-off-by: Fred Bricon <fbricon@gmail.com>
Turns out tycho 0.14.1 didn't report eclipse crashes (du to org.eclipse.swt.SWTError: No more handles [gtk_init_check() failed]) as test failures, so BuildHive builds appeared OK when they were not. Tycho 0.15.0 properly fails the build in that case.
Signed-off-by: Fred Bricon <fbricon@gmail.com>
Signed-off-by: Fred Bricon <fbricon@gmail.com>
Signed-off-by: Fred Bricon <fbricon@gmail.com>
Signed-off-by: Fred Bricon <fbricon@gmail.com>
Signed-off-by: Fred Bricon <fbricon@gmail.com>
Signed-off-by: Fred Bricon <fbricon@gmail.com>
Signed-off-by: Fred Bricon <fbricon@gmail.com>
Bumps [junit](https://github.com/junit-team/junit4) from 4.12 to 4.13.1. - [Release notes](https://github.com/junit-team/junit4/releases) - [Changelog](https://github.com/junit-team/junit4/blob/main/doc/ReleaseNotes4.12.md) - [Commits](junit-team/junit4@r4.12...r4.13.1) Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Leonid Rozenblyum <lrozenblyum@gmail.com>
Signed-off-by: Fred Bricon <fbricon@gmail.com>
Signed-off-by: Fred Bricon <fbricon@gmail.com>
Signed-off-by: Fred Bricon <fbricon@gmail.com>
Signed-off-by: Fred Bricon <fbricon@gmail.com>
- CI builds on master are automatically published to https://jbosstools.github.io/m2e-apt/snapshots/ - Release builds require pushing a tag following the vVERSION format (eg. v1.5.4). Update sites will then be published to: * https://jbosstools.github.io/m2e-apt/latest/ * https://jbosstools.github.io/m2e-apt/updates/VERSION Signed-off-by: Fred Bricon <fbricon@gmail.com>
Signed-off-by: Fred Bricon <fbricon@gmail.com>
Signed-off-by: Fred Bricon <fbricon@gmail.com>
Signed-off-by: Fred Bricon <fbricon@gmail.com>
Signed-off-by: Fred Bricon <fbricon@gmail.com>
Signed-off-by: Fred Bricon <fbricon@gmail.com>
Signed-off-by: Fred Bricon <fbricon@gmail.com>
mickaelistria
force-pushed
the
m2e=apt
branch
from
0da6693
to
ccd49be
Compare
And remove things not needed for migration to m2e
mickaelistria
force-pushed
the
m2e=apt
branch
from
ccd49be
to
5d67109
Compare
mickaelistria
force-pushed
the
m2e=apt
branch
from
5d67109
to
179edfd
Compare
|
Code was approved for a merge, so no need to wait for ECA. Merging (manually) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.