Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Discover m2e connector's "Finish" button doesn't work #1371

Closed
olkornii opened this issue May 9, 2023 · 2 comments · Fixed by #1410
Closed

[BUG] Discover m2e connector's "Finish" button doesn't work #1371

olkornii opened this issue May 9, 2023 · 2 comments · Fixed by #1410

Comments

@olkornii
Copy link

olkornii commented May 9, 2023

Steps to reproduce:

  1. File -> Import -> Maven -> Existing maven project
  2. Select maven project (ex. maven-wrong-project) -> click Finish
  3. Discover m2e connectors appears -> click "Resolve All Later" -> Finish -> nothing happens, no errors in error log
@laeubi
Copy link
Member

laeubi commented Jun 5, 2023

I have looked into this and its a bit strange as m2e tries to determine if the issues are "handled" before it allows to finish the wizard, but in fact I can't find any case where it is not valid to finish the wizard (even though in this case it is equivalent to cancel the wizard), I therefore will remove the check as it is already implemented badly by simply doing "nothing" instead of inform the user what to do.

laeubi added a commit to laeubi/m2e-core that referenced this issue Jun 5, 2023
@laeubi
Do not prevent finish for "incomplete" mappings
32a4389 
Currently in #finish of the wizard it can happen that the wizard do not
finish if m2e thinks the mapping is incomplete, but this is a very bad
user experience as there is not indication of what has to be done.

Instead a page should set its completion status (in this case the button
is disabled) and instruct the user what to do instead.

Fix eclipse-m2e#1371
@laeubi laeubi mentioned this issue Jun 5, 2023
Merged
laeubi added a commit that referenced this issue Jun 5, 2023
@laeubi
Do not prevent finish for "incomplete" mappings
3e19191 
Currently in #finish of the wizard it can happen that the wizard do not
finish if m2e thinks the mapping is incomplete, but this is a very bad
user experience as there is not indication of what has to be done.

Instead a page should set its completion status (in this case the button
is disabled) and instruct the user what to do instead.

Fix #1371
@olkornii olkornii mentioned this issue Jun 7, 2023
Closed
@olkornii
Copy link
Author

olkornii commented Jul 12, 2023 •
edited
Loading

@laeubi I've tried and still does not work for me with Eclipse 2023-06-R and Fedora 38.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not prevent finish for "incomplete" mappings laeubi/m2e-core
2 participants
@laeubi @olkornii