GH-272: Updated the API to support type hierarchies. #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 11, 2018
|
@kittaakos is this PR outdated? microsoft/vscode-languageserver-node#425 has been closed and microsoft/vscode-languageserver-node#426 looks a bit different. |
Yes.
Where do you see the difference? I must have overlooked something. |
kittaakos
changed the title
export interface TypeHierarchyCapabilities {
/**
* The text document client capabilities.
*/
textDocument?: {
/**
* `true` if the language client supports super- and subtype hierarchies. Otherwise, `false` or `undefined`.
*/
typeHierarchy?: boolean;
}
}vs. https://github.com/eclipse/lsp4j/pull/273/files#diff-d10742f66bf9c4b629c5e8252db884ba class TypeHierarchyCapabilities {
/**
* The language client supports super- and subtype hierarchies.
*/
Boolean typeHierarchy
new() {
}
new(Boolean typeHierarchy) {
this.typeHierarchy = typeHierarchy
}
}The first is just a Boolean, the second wraps it in an object. |
kittaakos
force-pushed
the
GH-272
branch
3 times, most recently
from
3e60964 to
27fa044
Compare
|
I have updated the PR based on this microsoft/vscode-languageserver-node#346 (comment). |
kittaakos
changed the title
spoenemann
reviewed
Jan 23, 2019
org.eclipse.lsp4j/src/main/java/org/eclipse/lsp4j/Protocol.xtend
Outdated
Show resolved
Hide resolved
Closes: eclipse-lsp4j#272 Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Signed-off-by: Akos Kitta <kittaakos@typefox.io>
spoenemann
approved these changes
Jan 24, 2019
adietish
pushed a commit
to adietish/lsp4j
that referenced
this pull request
Aug 20, 2024
Fixes eclipse-lsp4j#273 Signed-off-by: azerr <azerr@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a method
Closes: #272
Signed-off-by: Akos Kitta kittaakos@typefox.io