Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the assertion that makes the test fail #1155

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

rubenporras
Copy link
Contributor

No description provided.

@rubenporras rubenporras requested a review from sebthom December 5, 2024 09:54
@rubenporras rubenporras merged commit 52d9588 into eclipse-lsp4e:main Dec 5, 2024
2 of 6 checks passed
@rubenporras rubenporras deleted the fixRenameTest branch December 5, 2024 10:15
@rubenporras rubenporras changed the title Remove assertion that makes the test fail Move the assertion that makes the test fail Dec 5, 2024
@rubenporras
Copy link
Contributor Author

@sebthom, after this commit the test is passing on windows but not on Mac OS. I do not have access to any Mac OS where I could test locally. Since you have worked on this test before (and added the assertion), do you think you can take a look why the assertion started failing after the upgrade from Eclipse 2024-09 to Eclipse 2024-12?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant