refact: Use var keyword and List.of and Set.of where applicable
#1072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replaced explicit types with `var` for local variables where the type is clear due to the `new` keyword or implicit casting
This commit replaces usage of Collections.sort in places where currently the unsafe assumption is made that the input list is always mutable.
rubenporras
approved these changes
Aug 21, 2024
|
So after Jenkins can validate the PR, we should use "Rebase and Merge"? |
yes please. I usually only use squash when the PR contains unpolished commit messages or multiple commits trying to address the exact same issue. |
sebthom
changed the title
var keyword and List.of where applicablevar keyword and List.of and Set.of where applicable
|
Jenkins CI is down... |
|
Infra failures already reported at https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/4914 |
rubenporras
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please don't squash this commit when merging for better transparency of the changes.
This PR applies various refactorings to the code base, mainly:
varkeyword for local variable assignment where the actual type is immediately recognizable through an implicit cast or a constructor call on the right side of the assignementCollections.singletonListandArrays.asList(if beneficial) with Java 9'sList.ofCollections.sortin places where an unsafe assumption was made that the input list will always be mutable.