-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable string interpolation for Json launch parameters #756
Labels
enhancement
New feature or request
Comments
The relevant class seems to be |
@Si-So this is a very valid request. Would you be willing to submit a PR that enables it? |
@mickaelistria Yes, I am willing, but I don't know when I will find the time. Maybe next Tuesday. |
Si-So
added a commit
to Si-So/lsp4e
that referenced
this issue
Aug 31, 2023
Si-So
added a commit
to Si-So/lsp4e
that referenced
this issue
Aug 31, 2023
mickaelistria
pushed a commit
that referenced
this issue
Sep 1, 2023
2 tasks
akurtakov
added a commit
to akurtakov/lsp4e
that referenced
this issue
Nov 22, 2023
akurtakov
added a commit
to akurtakov/lsp4e
that referenced
this issue
Nov 22, 2023
mickaelistria
pushed a commit
that referenced
this issue
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to reproduce
The plugin does not perform string interpolation for the json launch parameters. In contrast to VS Code, which does (see here: https://github.com/microsoft/vscode-chrome-debug#launch and here: https://github.com/firefox-devtools/vscode-firefox-debug#launch)
Without string interpolation, it makes no sense to commit the launch configuration to git, because the configurations depend on the directory structure of the commiter. By enabling string interpolation, committing the launch configurations into git makes sense.
The text was updated successfully, but these errors were encountered: