Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable string interpolation for Json launch parameters #756

Closed
Si-So opened this issue Aug 11, 2023 · 3 comments · Fixed by #786
Closed

Enable string interpolation for Json launch parameters #756

Si-So opened this issue Aug 11, 2023 · 3 comments · Fixed by #786
Labels
enhancement New feature or request

Comments

@Si-So
Copy link
Contributor

Si-So commented Aug 11, 2023

Steps to reproduce

  1. Open the Debug Configuration Wizard
  2. Create a new configuration for the "Debug Adapter Launcher"
  3. Enter valid json in the "Launch parameters" textbox. For example:
{
    "webRoot":"${workspace_loc:/some_project}",
}

The plugin does not perform string interpolation for the json launch parameters. In contrast to VS Code, which does (see here: https://github.com/microsoft/vscode-chrome-debug#launch and here: https://github.com/firefox-devtools/vscode-firefox-debug#launch)

Without string interpolation, it makes no sense to commit the launch configuration to git, because the configurations depend on the directory structure of the commiter. By enabling string interpolation, committing the launch configurations into git makes sense.

@Si-So
Copy link
Contributor Author

Si-So commented Aug 11, 2023

The relevant class seems to be DSPLaunchDelegate.java

@mickaelistria mickaelistria added the enhancement New feature or request label Aug 17, 2023
@mickaelistria
Copy link
Contributor

@Si-So this is a very valid request. Would you be willing to submit a PR that enables it?

@Si-So
Copy link
Contributor Author

Si-So commented Aug 18, 2023

@mickaelistria Yes, I am willing, but I don't know when I will find the time. Maybe next Tuesday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants