Minor enhancement on RedisRegistrationStore #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msangoi
approved these changes
Nov 10, 2017
| /** Default time in seconds between 2 cleaning tasks (used to remove expired registration). */ | ||
| public static final long DEFAULT_CLEAN_PERIOD = 60; | ||
| /** Defaut Extra time for registration lifetime in seconds */ | ||
| public static final long DEFAULT_CLEMENCY = 0; |
There was a problem hiding this comment.
what do you think of renaming "clemency" to "grace period"? again a naming question ;)
There was a problem hiding this comment.
I will change it
| return isAlive(0); | ||
| } | ||
|
|
||
| public boolean isAlive(long clemencyInSec) { |
There was a problem hiding this comment.
I think this method needs a proper javadoc, in order to understand the meaning of this grace/clemency period.
And the default isAlive() as well.
sbernard31
force-pushed
the
redisregstore_enhancement
branch
from
501c90e
to
3b8e7a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some potential race condition issue an add kind of clemency for expiration.