-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor enhancement on RedisRegistrationStore #402
Conversation
/** Default time in seconds between 2 cleaning tasks (used to remove expired registration). */ | ||
public static final long DEFAULT_CLEAN_PERIOD = 60; | ||
/** Defaut Extra time for registration lifetime in seconds */ | ||
public static final long DEFAULT_CLEMENCY = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you think of renaming "clemency" to "grace period"? again a naming question ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will change it
return isAlive(0); | ||
} | ||
|
||
public boolean isAlive(long clemencyInSec) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this method needs a proper javadoc, in order to understand the meaning of this grace/clemency period.
And the default isAlive()
as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can try
501c90e
to
3b8e7a9
Compare
Fix some potential race condition issue an add kind of clemency for expiration.