-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move SecurityMode from leshan-server-core to leshan-core #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbernard31
force-pushed
the
move_securitymode
branch
from
January 18, 2017 14:46
77e3dc3
to
6f222a3
Compare
msangoi
reviewed
Jan 20, 2017
} | ||
|
||
public static SecurityMode fromCode(int code) { | ||
switch (code) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Less error prone to iterate over values().
@@ -290,6 +290,8 @@ public void run() { | |||
} | |||
} catch (InterruptedException e) { | |||
LOG.info("Registration task interrupted."); | |||
} catch (RuntimeException e) { | |||
LOG.error("Unexpected exception pending update registration task", e); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: "during update registration"
sbernard31
force-pushed
the
move_securitymode
branch
from
January 20, 2017 14:51
6f222a3
to
323839b
Compare
It's fixed. |
msangoi
approved these changes
Jan 20, 2017
sbernard31
force-pushed
the
move_securitymode
branch
from
January 23, 2017 13:43
323839b
to
2d0a43b
Compare
mike-scott
pushed a commit
to mike-scott/leshan
that referenced
this pull request
Jan 31, 2018
…ipse-leshan#249) * Provide proper OSGi meta-data for all modules eclipse-leshan#248 Signed-off-by: Dirk Fauth <dirk.fauth@googlemail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I move SecurityMode from leshan-server-core to leshan-core to be able to reuse it in leshan-client.