Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"BootstrapConfig" should be a list of request #437

Closed
sbernard31 opened this issue Nov 15, 2017 · 3 comments
Closed

"BootstrapConfig" should be a list of request #437

sbernard31 opened this issue Nov 15, 2017 · 3 comments
Labels
bsserver Impact LWM2M bootstrap server new feature New feature from LWM2M specification
Milestone

Comments

@sbernard31
Copy link
Contributor

Currently the bootstrap server is configurable by adding a bootstrapConfig for a given endpoint.

This bootstrap config is a list of Security objects and Server objects.
A bootstrap session will start by a Delete on / then a Write request for each Security objects then a Write request for each Server objects.
This is not so flexible.

The bootstrapConfig should rather be a list of requests (write,delete) to send.
This allow to :

  • support all objects,
  • do not force to start with delete "/" (delete only object you need to delete),
  • do request in different order.

But this will not cover cases where we need to make complex processing (using discover, using previous result to guess what to send ... ... ), I don't know what this might look like.

@sbernard31
Copy link
Contributor Author

After several thoughts and tries about making the BootstrapConfig more flexible we finally think this is maybe not a so good Idea.

We try to implement this in #883 and as explained at #883 (comment) this bring new issues ...
This makes make us feel there is no way to provide a kind of Bootstrap Config which could supports correctly all use-cases.

Those makes us think that maybe we should keep BootstrapConfig which aims to :

  • be easy/straightforward to use for main use cases.
  • but with limited feature.

In addition, the code should be refactored to make easier to integrate custom behavior and so support all cases.

This means that recent addition of #883 was probably a bad idea and will be removed/replaced by new classes.

@sbernard31
Copy link
Contributor Author

sbernard31 commented Jun 10, 2021

#1027 is a new try to achieve those goals.

sbernard31 added a commit that referenced this issue Jun 10, 2021
After more thoughts, we decide that this was not the good approach. See
#437 (comment) for
more details.

Consequences BootstrapConfig is no more deprecated.
sbernard31 added a commit that referenced this issue Jun 25, 2021
After more thoughts, we decide that this was not the good approach. See
#437 (comment) for
more details.

Consequences BootstrapConfig is no more deprecated.
@sbernard31
Copy link
Contributor Author

I think #1027 achieve this goal.
This new API will be available in Leshan v2.0.0 since M4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bsserver Impact LWM2M bootstrap server new feature New feature from LWM2M specification
Projects
None yet
Development

No branches or pull requests

1 participant