Patch containerd service unit to be After=data.mount on power on #90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The kanto-CM service unit being dependent on the
data.mount
provided a partial fix for the issue of improperly un-mounting the /data partition (most cases whenshutdown now
andpoweroff
were used).However, containerd might continue to use /data even after kanto-cm is stopped, leading to improper un-mounting of the partition when the system was rebooted very soon after startup for example.
Fix
A similar patch for the containerd service unit was provided that makes it depend on the data.mount service on startup (services are stopped in the reverse order on power-off).
Testing
A qemux86-64 and a qemuarm64 leda-distro builds were tested. The system was shut off quickly after a build, rebooted via
reboot now
and so on. No cases of improper dismount of /data were observedPower-off logs
From the logs it can be observed that the order of services being stopped is: