-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kanto auto deployer #49
Kanto auto deployer #49
Conversation
Signed-off-by: Stoyan Lachev <stoyan.lachev@bosch.io>
Signed-off-by: Stoyan Lachev <stoyan.lachev@bosch.io>
Signed-off-by: Stoyan Lachev <stoyan.lachev@bosch.io>
Cargo.lock seems to be cached |
Signed-off-by: Stoyan Lachev <stoyan.lachev@bosch.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The databroker.json is still part of the kanto-auto-deployer recipe.
It should be a separate recipe.
WantedBy=multi-user.target | ||
|
||
[Service] | ||
ExecStart=/usr/bin/kanto-auto-deployer /manifests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should go to /var/containers/manifests by default. Having new folders in the root is not really recommended, as the root should be as user friendly as possible.
FILES:${PN} += "${systemd_unitdir}/system/kanto-auto-deployer.service" | ||
|
||
#containers | ||
FILES:${PN} += "/manifests/databroker.json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The list of containers should not be part of the kanto-auto-deployer recipe imho.
Someone who wants to use the kanto-auto-deployer recipe for his own setup would be bound to the same list of containers.
Signed-off-by: Stoyan Lachev <stoyan.lachev@bosch.io>
No description provided.