Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata v2 value restriction #77

Conversation

rafaeling
Copy link
Contributor

No description provided.

@rafaeling rafaeling requested a review from lukasmittag October 2, 2024 12:55
@rafaeling rafaeling changed the base branch from main to feature/databroker-api-v2 October 2, 2024 12:55
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 1.11732% with 177 lines in your changes missing coverage. Please review.

Please upload report for BASE (feature/databroker-api-v2@4eee61c). Learn more about missing BASE report.

Files with missing lines Patch % Lines
databroker/src/grpc/kuksa_val_v2/val.rs 2.04% 96 Missing ⚠️
databroker/src/grpc/kuksa_val_v2/conversions.rs 0.00% 81 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                      @@
##             feature/databroker-api-v2      #77   +/-   ##
============================================================
  Coverage                             ?   51.01%           
============================================================
  Files                                ?       33           
  Lines                                ?    13070           
  Branches                             ?        0           
============================================================
  Hits                                 ?     6668           
  Misses                               ?     6402           
  Partials                             ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@erikbosch erikbosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and Ready for Review, so merging

@erikbosch erikbosch merged commit ea34809 into eclipse-kuksa:feature/databroker-api-v2 Oct 3, 2024
23 checks passed
@erikbosch erikbosch deleted the feature/add-metadata-v2-value-restriction branch October 3, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants