Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [Messaging] Introduced configuration to optionally skip Device.id resolution for KapuaDataMessage #4058

Conversation

Coduz
Copy link
Contributor

@Coduz Coduz commented Jun 18, 2024

This PR intrduces a new Setting for KapuaKuraDataTranslator to skip optionally the Device.id resolution form the DataChannel.clientId

Related Issue
None

Description of the solution adopted
Added a new Setting to control whether the Device.id resolution will be performed or not.

Screenshots
If applicable, add screenshots to help explain your solution

Any side note on the changes made
This can improve performances in certain scenarios

@Coduz Coduz added the Enhancement This PR/Issue improves an part of Kapua label Jun 18, 2024
@Coduz Coduz force-pushed the feat-dataTranslatorOptionalDeviceIdResolution branch 2 times, most recently from c59d9c5 to 2ca2cd4 Compare June 18, 2024 13:16
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 6.66667% with 14 lines in your changes missing coverage. Please review.

Project coverage is 16.81%. Comparing base (6083dcf) to head (8bf666e).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4058      +/-   ##
=============================================
- Coverage      16.81%   16.81%   -0.01%     
  Complexity        22       22              
=============================================
  Files           2006     2008       +2     
  Lines          52101    52113      +12     
  Branches        4386     4387       +1     
=============================================
+ Hits            8762     8763       +1     
- Misses         42946    42957      +11     
  Partials         393      393              
Files Coverage Δ
...e/kapua/translator/KapuaKuraTranslatorsModule.java 97.95% <100.00%> (+0.04%) ⬆️
...ranslator/setting/TranslatorKapuaKuraSettings.java 0.00% <0.00%> (ø)
...translator/kura/kapua/TranslatorDataKuraKapua.java 0.00% <0.00%> (ø)
...slator/setting/TranslatorKapuaKuraSettingKeys.java 0.00% <0.00%> (ø)

@Coduz Coduz force-pushed the feat-dataTranslatorOptionalDeviceIdResolution branch from 2ca2cd4 to cdd7999 Compare June 19, 2024 13:13
…esolution for KapuaDataMessage

Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
@Coduz Coduz force-pushed the feat-dataTranslatorOptionalDeviceIdResolution branch from cdd7999 to 8bf666e Compare June 19, 2024 13:28
@Coduz Coduz merged commit 9ab98f4 into eclipse-kapua:develop Jun 19, 2024
34 of 35 checks passed
@Coduz Coduz deleted the feat-dataTranslatorOptionalDeviceIdResolution branch June 19, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement This PR/Issue improves an part of Kapua
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants