Add preference to update snapshots for Maven projects #1217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Snjezana Peco <snjezana.peco@redhat.com>
fbricon
reviewed
Oct 21, 2019
| @@ -177,6 +179,42 @@ public void testDownloadSources() throws Exception { | |||
| assertNotNull(source); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testUpdateSnapshots() throws Exception { | |||
There was a problem hiding this comment.
Does this test fail without the fix?
There was a problem hiding this comment.
No, it doesn't fail. We are testing whether a dependency has actually been added when using the new preference.
There was a problem hiding this comment.
if it doesn't fail with or without the fix, then the test proves nothing
There was a problem hiding this comment.
The new preference doesn't add any functionality. It just enhances performance. We are testing whether it breaks the update maven project action.
There was a problem hiding this comment.
@fbricon Do you want me to remove this test?
fbricon
changed the title
fbricon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes redhat-developer/vscode-java#1102
Requires redhat-developer/vscode-java#1109
Signed-off-by: Snjezana Peco snjezana.peco@redhat.com