Iox #59 memory abstraction modularization roudi fixes #60

marthtz · 2020-03-06T11:01:00Z

No description provided.

Signed-off-by: Hintz Martin (CC-AD/ESW1) <martin.hintz@de.bosch.com>

marthtz · 2020-03-06T11:12:36Z

Do we intend to supply a default "roudi_config.toml"?

elBoberido · 2020-03-06T11:27:49Z

README.md

@@ -89,7 +89,7 @@ Although we strive to be fully POSIX-compliant, we recommend using Ubuntu 18.04

 You will need to install the following packages:

-    sudo apt install cmake libacl1-dev libncurses5-dev pkg-config
+    sudo apt-get install cmake libacl1-dev libncurses5-dev pkg-config


I think I saw a PR which removed the "-get" and it seems it's the recommended way since some time
see https://itsfoss.com/apt-vs-apt-get-difference/

Wasn't aware of that. Thought it's a typo! ;)
Fixed.

elBoberido · 2020-03-06T11:33:29Z

iceoryx_posh/CMakeLists.txt

    INCLUDE_DIRECTORY include/
 )
+if(TOML_CONFIG)
+    setup_install_directories_and_export_package(


I'm not sure this can be called twice, have to check

Was working fine, when I tested it.

elBoberido · 2020-03-06T11:42:16Z

iceoryx_posh/source/popo/publisher.cpp

 {
 }

-Publisher::~Publisher() noexcept
-{
-    m_sender.destroy();


are we sure about removing this?

Not at all, we just introduced it

elBoberido · 2020-03-06T11:49:20Z

iceoryx_utils/include/iceoryx_utils/cxx/expected.hpp

-    /// @brief copy conversion constructor to convert an expected which contains value and
-    ///        error type to an expected which contains only an error
-    template <typename ValueType>
-    expected(const expected<ValueType, ErrorType>& rhs) noexcept;


@elfenpiff is this correct or an merge error?

This is special handling for Win/MSVC. Added code and #if WIN32 to fix it.

elBoberido · 2020-03-06T11:50:36Z

iceoryx_utils/include/iceoryx_utils/cxx/optional.hpp

@@ -124,7 +125,7 @@ class optional
    /// @param[in] value value to assign to the underlying optional value
    /// @return reference to the current optional
    template <typename U = T>
-    typename ::std::enable_if<!::std::is_same<U, optional<T>&>::value, optional>::type& operator=(U&& value) noexcept;
+    typename std::enable_if<!std::is_same<U, optional<T>&>::value, optional>::type& operator=(U&& value) noexcept;


@elfenpiff is this correct or a merge error?

In all other code references it's std:: and not ::std::.

elBoberido · 2020-03-06T11:51:29Z

iceoryx_utils/include/iceoryx_utils/internal/cxx/optional.inl

@@ -109,7 +109,7 @@ inline optional<T>::~optional() noexcept

 template <typename T>
 template <typename U>
-inline typename ::std::enable_if<!::std::is_same<U, optional<T>&>::value, optional<T>>::type& optional<T>::


@elfenpiff is this correct or a merge error?

elBoberido · 2020-03-06T11:57:45Z

iceoryx_utils/test/moduletests/test_relative_pointer.cpp

 #include "test.hpp"

 #include <cstdint>
 #include <cstring>
+#include <fcntl.h> /* For O_* constants */


I think all the changes in this file are due to merge errors

mossmaurice · 2020-03-06T11:59:45Z

Do we intend to supply a default "roudi_config.toml"?

Yes, we do.

mossmaurice · 2020-03-06T12:09:17Z

iceoryx_posh/CMakeLists.txt

@@ -1,5 +1,5 @@
 cmake_minimum_required(VERSION 3.5)
-set(iceoryx_posh_VERSION 0.16.0.1)
+set(iceoryx_posh_VERSION 0.16.0.3)


There is already a 0.16.1 release and the version wasn‘t updated properly. Please set to 0.16.1 @dkroenke Is that ok?

mossmaurice · 2020-03-06T12:21:29Z

iceoryx_utils/CMakeLists.txt

@@ -1,5 +1,5 @@
 cmake_minimum_required(VERSION 3.5)
-set(iceoryx_utils_VERSION 0.16.0.1)
+set(iceoryx_utils_VERSION 0.16.0.3)


Please update version to 0.16.1

mossmaurice · 2020-03-06T12:22:27Z

iceoryx_utils/include/iceoryx_utils/internal/cxx/expected.inl

@@ -327,58 +327,6 @@ inline expected<ErrorType>::expected(error<ErrorType>&& errorValue) noexcept
 {
 }

-template <typename ErrorType>


Removed by error?

This is special handling for Win/MSVC. Added code and #if WIN32 to fix it.

mossmaurice · 2020-03-06T12:25:18Z

tools/introspection/CMakeLists.txt

@@ -1,5 +1,5 @@
 cmake_minimum_required(VERSION 3.5)
-set(iceoryx_introspection_VERSION 0.16.0.1)
+set(iceoryx_introspection_VERSION 0.16.0.3)


Please update the version to 0.16.1

Signed-off-by: Hintz Martin (CC-AD/ESW1) <martin.hintz@de.bosch.com>

marthtz added 2 commits March 6, 2020 12:08

iox-eclipse-iceoryx#32 update example readme

522f7d4

Signed-off-by: Hintz Martin (CC-AD/ESW1) <martin.hintz@de.bosch.com>

iox-eclipse-iceoryx#59 Memory abstraction, modularization roudi, fixes

6918394

Signed-off-by: Hintz Martin (CC-AD/ESW1) <martin.hintz@de.bosch.com>

marthtz force-pushed the iox-#59-memory-abstraction-modularization-roudi-fixes branch from d764b7b to 6918394 Compare March 6, 2020 11:09

elBoberido requested changes Mar 6, 2020

View reviewed changes

mossmaurice added the enhancement New feature label Mar 6, 2020

mossmaurice requested review from budrus, elfenpiff and mossmaurice March 6, 2020 12:00

mossmaurice reviewed Mar 6, 2020

View reviewed changes

marthtz added 2 commits March 6, 2020 14:45

iox-eclipse-iceoryx#59 Fix apt command in readme

9deabf7

Signed-off-by: Hintz Martin (CC-AD/ESW1) <martin.hintz@de.bosch.com>

iox-eclipse-iceoryx#59 Fix publisher dtor

7fcf7de

Signed-off-by: Hintz Martin (CC-AD/ESW1) <martin.hintz@de.bosch.com>

marthtz closed this Mar 6, 2020

mossmaurice linked an issue Mar 24, 2020 that may be closed by this pull request

string with fixed but compile-time configurable capacity #53

Closed

mossmaurice removed a link to an issue Mar 24, 2020

string with fixed but compile-time configurable capacity #53

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Iox #59 memory abstraction modularization roudi fixes #60

Iox #59 memory abstraction modularization roudi fixes #60

marthtz commented Mar 6, 2020

marthtz commented Mar 6, 2020

elBoberido Mar 6, 2020

marthtz Mar 6, 2020 •

edited

Loading

elBoberido Mar 6, 2020

mossmaurice Mar 6, 2020

elBoberido Mar 6, 2020

budrus Mar 6, 2020

marthtz Mar 6, 2020

elBoberido Mar 6, 2020

marthtz Mar 6, 2020

elBoberido Mar 6, 2020

marthtz Mar 6, 2020

elBoberido Mar 6, 2020

elBoberido Mar 6, 2020

marthtz Mar 6, 2020

mossmaurice commented Mar 6, 2020

mossmaurice Mar 6, 2020 •

edited

Loading

mossmaurice Mar 6, 2020

mossmaurice Mar 6, 2020

marthtz Mar 6, 2020

mossmaurice Mar 6, 2020

Iox #59 memory abstraction modularization roudi fixes #60

Iox #59 memory abstraction modularization roudi fixes #60

Conversation

marthtz commented Mar 6, 2020

marthtz commented Mar 6, 2020

Choose a reason for hiding this comment

marthtz Mar 6, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mossmaurice commented Mar 6, 2020

mossmaurice Mar 6, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

marthtz Mar 6, 2020 •

edited

Loading

mossmaurice Mar 6, 2020 •

edited

Loading