Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#271: Fix name clash #272

Conversation

marthtz
Copy link
Contributor

@marthtz marthtz commented Sep 7, 2020

Signed-off-by: Hintz Martin (CC-AD/ESW1) martin.hintz@de.bosch.com

Signed-off-by: Hintz Martin (CC-AD/ESW1) <martin.hintz@de.bosch.com>
@dkroenke dkroenke linked an issue Sep 7, 2020 that may be closed by this pull request
@dkroenke dkroenke self-requested a review September 7, 2020 11:02
@dkroenke dkroenke added the bugfix Solves a bug label Sep 7, 2020
elBoberido
elBoberido previously approved these changes Sep 7, 2020
@codecov
Copy link

codecov bot commented Sep 7, 2020

Codecov Report

Merging #272 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #272      +/-   ##
==========================================
- Coverage   62.18%   62.16%   -0.02%     
==========================================
  Files         296      296              
  Lines        9213     9212       -1     
  Branches     1727     1727              
==========================================
- Hits         5729     5727       -2     
  Misses       2469     2469              
- Partials     1015     1016       +1     
Impacted Files Coverage Δ
iceoryx_posh/source/roudi/roudi_process.cpp 54.88% <0.00%> (+0.18%) ⬆️
iceoryx_utils/source/posix_wrapper/timer.cpp 65.67% <0.00%> (-0.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ede59b8...91fd454. Read the comment docs.

dkroenke
dkroenke previously approved these changes Sep 7, 2020
Signed-off-by: Kroenke Dietrich (CC-AD/ESW1) <Dietrich.Kroenke2@de.bosch.com>
@dkroenke dkroenke dismissed stale reviews from elBoberido and themself via 91fd454 September 7, 2020 11:17
@elBoberido
Copy link
Member

it seems someone accidentally disabled the warnings with #178
https://github.com/eclipse/iceoryx/pull/178/files?file-filters%5B%5D=.cpp&file-filters%5B%5D=.hpp&file-filters%5B%5D=.inl&file-filters%5B%5D=.sh&file-filters%5B%5D=.txt&file-filters%5B%5D=.yml#diff-ec2db60457389b7b9b8ed6a45914454dR20
It should be set(ICEORYX_WARNINGS instead of set(TEST_CXX_FLAGS

Signed-off-by: Kroenke Dietrich (CC-AD/ESW1) <Dietrich.Kroenke2@de.bosch.com>
@dkroenke dkroenke self-requested a review September 7, 2020 12:52
@dkroenke dkroenke merged commit a757f75 into eclipse-iceoryx:master Sep 7, 2020
@marthtz marthtz deleted the iox-#271-name-clash-in-roudi-process-removeprocess branch December 18, 2020 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Solves a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Name clash in RouDi process removeProcess()
3 participants