Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#846 Make default config file location configurable #2411

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Jan 10, 2025

Notes for Reviewer

Since command line parameters are not yet supported for RouDi on Windows, this PR introduces a cmake option to set the location where RouDi looks for the default configuration.

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Checklist for the PR Reviewer

  • Consider a second reviewer for complex new features or larger refactorings
  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Copy link
Contributor

@elfenpiff elfenpiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this also to the release notes then we can merge it.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 78.68%. Comparing base (b4f81fc) to head (5cd467c).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...h/source/roudi/roudi_config_toml_file_provider.cpp 16.66% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2411      +/-   ##
==========================================
- Coverage   78.69%   78.68%   -0.02%     
==========================================
  Files         440      440              
  Lines       16981    16986       +5     
  Branches     2361     2361              
==========================================
+ Hits        13364    13365       +1     
- Misses       2736     2740       +4     
  Partials      881      881              
Flag Coverage Δ
unittests 78.48% <16.66%> (-0.02%) ⬇️
unittests_timing 15.35% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...h/source/roudi/roudi_config_toml_file_provider.cpp 87.50% <16.66%> (-4.50%) ⬇️

@elBoberido elBoberido requested a review from elfenpiff January 10, 2025 18:59
@elBoberido elBoberido force-pushed the iox-846-make-default-config-file-location-configurable branch from 6971919 to 02c25ec Compare January 10, 2025 19:00
@elBoberido elBoberido force-pushed the iox-846-make-default-config-file-location-configurable branch from 02c25ec to 5cd467c Compare January 10, 2025 19:00
@elBoberido elBoberido merged commit f33d582 into eclipse-iceoryx:main Jan 11, 2025
23 checks passed
@elBoberido elBoberido deleted the iox-846-make-default-config-file-location-configurable branch January 11, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants