iox-eclipse-iceoryx#2040 support for iox::string in UnixDomainSocket #2122
Task list completed / task-list-completed
succeeded
Jan 13, 2024 in 0s
20 / 20 tasks completed
All tasks have been completed
Details
Required Tasks
| Task | Status |
|---|---|
| Add a second reviewer for complex new features or larger refactorings | Completed |
| Code follows the coding style of [CONTRIBUTING.md][contributing] | Completed |
| Tests follow the [best practice for testing][testing] | Completed |
| Changelog updated [in the unreleased section][changelog] including API breaking changes | Completed |
Branch follows the naming format (iox-123-this-is-a-branch) |
Completed |
Commit messages have the issue ID (iox-#123 commit text) |
Completed |
| Commit author matches [Eclipse Contributor Agreement][eca] (and ECA is signed) | Completed |
| Follow the same conventions as for commit messages | Incomplete |
| Link to the relevant issue | Incomplete |
| Relevant issues are linked | Completed |
| Add sensible notes for the reviewer | Completed |
All checks have passed (except task-list-completed) |
Completed |
All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt |
Completed |
| Assign PR to reviewer | Completed |
| Commits are properly organized and messages are according to the guideline | Completed |
| Code according to our coding style and naming conventions | Completed |
| Unit tests have been written for new behavior | Completed |
| Public API changes are documented via doxygen | Completed |
| Copyright owner are updated in the changed files | Completed |
All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt |
Completed |
| PR title describes the changes | Completed |
| All open points are addressed and tracked via issues | Completed |
| Reference: #2040 | Incomplete |
| Reference: #1693 | Incomplete |
add this comment to the other places were sendImpl is used with a timeout of 0 |
Incomplete |
create a timedSendImpl which will be called from sendImpl; sendImpl would then have this comment |
Incomplete |
| this basically means to set the null-termination at the end of the buffer | Incomplete |
| has the disadvantage that one cannot receive the max amount of data that can be sent | Incomplete |
| the disadvantage is that it is a behavioral change (might count as bugfix though) | Incomplete |
| one can receive as many bytes as one can send | Incomplete |
Loading