Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iox #1311 increase version to 2.0.1 #1312

Conversation

dkroenke
Copy link
Member

@dkroenke dkroenke commented Apr 1, 2022

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-#123-this-is-a-branch)
  5. Commits messages are according to this guideline
    • Commit messages have the issue ID (iox-#123 commit text)
    • Commit messages are signed (git commit -s)
    • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Notes for Reviewer

Preparation for iceoryx bugfix release

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
    • Each unit test case has a unique UUID
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@dkroenke dkroenke self-assigned this Apr 1, 2022
@dkroenke dkroenke changed the base branch from master to release_2.0 April 1, 2022 09:59
@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #1312 (cc20019) into release_2.0 (cbd079f) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           release_2.0    #1312      +/-   ##
===============================================
+ Coverage        78.92%   78.95%   +0.02%     
===============================================
  Files              370      370              
  Lines            14705    14705              
  Branches          2059     2059              
===============================================
+ Hits             11606    11610       +4     
+ Misses            2418     2412       -6     
- Partials           681      683       +2     
Flag Coverage Δ
unittests 78.18% <ø> (+0.02%) ⬆️
unittests_timing 15.49% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lude/iceoryx_posh/internal/popo/base_publisher.hpp 100.00% <ø> (ø)
...lude/iceoryx_posh/internal/popo/publisher_impl.hpp 100.00% <ø> (ø)
...oryx_posh/internal/popo/untyped_publisher_impl.hpp 100.00% <ø> (ø)
iceoryx_hoofs/source/concurrent/loffli.cpp 80.00% <0.00%> (-5.72%) ⬇️
iceoryx_posh/source/roudi/port_manager.cpp 85.36% <0.00%> (+1.12%) ⬆️

@dkroenke dkroenke force-pushed the iox-#1311-increase-version-to-2.0.1 branch from f8dd49d to 4af7fbd Compare April 1, 2022 10:46
elBoberido
elBoberido previously approved these changes Apr 1, 2022
@dkroenke dkroenke requested a review from MatthiasKillat April 1, 2022 12:21
@elBoberido elBoberido force-pushed the iox-#1311-increase-version-to-2.0.1 branch from 8e0f833 to 9fb5b2f Compare April 1, 2022 14:19
@elBoberido elBoberido force-pushed the iox-#1311-increase-version-to-2.0.1 branch from 9fb5b2f to cc20019 Compare April 1, 2022 14:20
@dkroenke
Copy link
Member Author

dkroenke commented Apr 1, 2022

Build on ROS 2 CI (iceoryx only):

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@mossmaurice mossmaurice added bugfix Solves a bug documentation Improvements or additions to documentation and removed bugfix Solves a bug labels Apr 1, 2022
@dkroenke dkroenke merged commit ebdfcc5 into eclipse-iceoryx:release_2.0 Apr 1, 2022
@dkroenke dkroenke deleted the iox-#1311-increase-version-to-2.0.1 branch April 1, 2022 15:04
@dkroenke dkroenke restored the iox-#1311-increase-version-to-2.0.1 branch April 1, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants